[GitHub] [airflow] o-nikolas commented on a diff in pull request #29962: Separate cli_parser.py into two modules

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #29962:
URL: https://github.com/apache/airflow/pull/29962#discussion_r1130222797


##########
airflow/cli/cli_config.py:
##########
@@ -0,0 +1,2250 @@
+#!/usr/bin/env python
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Command-line interface."""

Review Comment:
   > Can we use docstrings of both modules to better describe what they do?
   
   Sure, good suggestion, I'll add those.
   
   >(As a separate issue, calling the modules cli_parser and cli_config seems redundant since they are already in a cli subpackage. It’s probably difficult to rename cli_parser, but we can name the new module config.)
   
   As you said `cli_parser.py` is difficult to change at this point and given that, I think it's cleaner to have both with the same naming format. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org