You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:35:02 UTC
[GitHub] [kafka] ijuma opened a new pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work
ijuma opened a new pull request #8728:
URL: https://github.com/apache/kafka/pull/8728
- Avoid tuple allocations by using `foreachEntry` and `update` methods
- Use `empty` instead of `apply` to avoid unnecessary array allocation
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8728:
URL: https://github.com/apache/kafka/pull/8728#issuecomment-634194854
`foreachEntry` doesn't exist in Scala 2.12, so will have to revert that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #8728:
URL: https://github.com/apache/kafka/pull/8728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8728:
URL: https://github.com/apache/kafka/pull/8728#issuecomment-635083240
Unrelated flaky failures:
> org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
> org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8728:
URL: https://github.com/apache/kafka/pull/8728#issuecomment-634623654
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org