[GitHub] [beam] pabloem commented on a change in pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #11582:
URL: https://github.com/apache/beam/pull/11582#discussion_r443832544



##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -1529,3 +1530,180 @@ def display_data(self):
         'source': DisplayDataItem(self.source.__class__, label='Read Source'),
         'source_dd': self.source
     }
+
+
+class SDFBoundedSourceReader(PTransform):
+  """A ``PTransform`` that uses SDF to read from each ``BoundedSource`` in a
+  PCollection.
+
+  NOTE: This transform can only be used with beam_fn_api enabled.
+  """
+  class _SDFBoundedSourceRestriction(object):

Review comment:
       This significantly duplicates functionality from `_SDFBoundedSourceWrapper` above - do you think you could have a single implementation instead of duplicating a lot of this functionality?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org