[GitHub] [hadoop] jianghuazhu commented on a change in pull request #2256: HDFS-15546. Remove duplicate initializeGenericKeys method when creating DFSZKFailoverController

[GitBox <gi...@apache.org>]

jianghuazhu commented on a change in pull request #2256:
URL: https://github.com/apache/hadoop/pull/2256#discussion_r479424352



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
##########
@@ -158,7 +158,7 @@ public static DFSZKFailoverController create(Configuration conf) {
           "You may run zkfc on the node other than namenode.";
       throw new HadoopIllegalArgumentException(msg);
     }
-    NameNode.initializeGenericKeys(localNNConf, nsId, nnId);

Review comment:
       NameNode.initializeGenericKeys(), this method will be called twice. In addition to this, it will be called once when NNHAServiceTarget() is initialized. Therefore, it can be deleted here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org