You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "miles-ton (via GitHub)" <gi...@apache.org> on 2023/04/16 08:39:02 UTC

[GitHub] [rocketmq] miles-ton opened a new issue, #6594: ACL PlainPermissionChecker.check confusion

miles-ton opened a new issue, #6594:
URL: https://github.com/apache/rocketmq/issues/6594

   <img width="1007" alt="image" src="https://user-images.githubusercontent.com/77013030/232286712-fe9ff484-9a53-4738-8602-05f5c0a2b294.png">
   1. i found the a very confused code segment in PlainPermissionChecker.check, dose the firs segment in frame above want  to indicate that the admin have any permission and don't need verification? if that's the case, why still go through the verification when ownedPermMap isn't null?
   2. what does 'isGroup' do, is it the duplicated code for the second and third red frame?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] drpmma commented on issue #6594: ACL PlainPermissionChecker.check confusion

Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on issue #6594:
URL: https://github.com/apache/rocketmq/issues/6594#issuecomment-1512503842

   Good catch! I will assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] miles-ton commented on issue #6594: ACL PlainPermissionChecker.check confusion

Posted by "miles-ton (via GitHub)" <gi...@apache.org>.
miles-ton commented on issue #6594:
URL: https://github.com/apache/rocketmq/issues/6594#issuecomment-1510786147

   > 1. agree with you, if admin, it could stop to do verification
   > 2. retry topic does not have any acl in files, if resource is a retry topic, it check the default group's acl
   
   thanks for your explanation, i will give out a PR to fix 1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] francisoliverlee commented on issue #6594: ACL PlainPermissionChecker.check confusion

Posted by "francisoliverlee (via GitHub)" <gi...@apache.org>.
francisoliverlee commented on issue #6594:
URL: https://github.com/apache/rocketmq/issues/6594#issuecomment-1510615300

   1.  agree with you, if admin, it could stop to do verification
   2. retry topic does not have any acl in files, if resource is a retry topic, it check the default group's acl


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] aaron-ai closed issue #6594: ACL PlainPermissionChecker.check confusion

Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai closed issue #6594: ACL PlainPermissionChecker.check confusion
URL: https://github.com/apache/rocketmq/issues/6594


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org