[GitHub] [spark] Hisoka-X commented on a diff in pull request #42110: [SPARK-42098][SQL] Fix ResolveInlineTables can not handle with RuntimeReplaceable expression

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #42110:
URL: https://github.com/apache/spark/pull/42110#discussion_r1270742510


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala:
##########
@@ -113,7 +115,7 @@ object ResolveInlineTables extends Rule[LogicalPlan] with CastSupport with Alias
           } else {
             cast(e, targetType)
           }
-          castedExpr.eval()
+          ReplaceExpressions.replace(castedExpr).eval()

Review Comment:
   This way is not particularly elegant, but it is a reasonable method among the several methods I have tried so far.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org