You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/05/23 08:13:48 UTC

[GitHub] [calcite] asolimando commented on pull request #2782: [CALCITE-5118] SqlDatePartFunction#rewriteCall should check operands length

asolimando commented on PR #2782:
URL: https://github.com/apache/calcite/pull/2782#issuecomment-1134334337

   Considering the following:
   - There is agreement in the Jira discussion that the current minimal fix is improving even if not addressing the "general issues" (where validation should happen, which does not only affect this rewrite but others too) 
   -  https://issues.apache.org/jira/browse/CALCITE-5167 has been filed to address the "general issue"
   - There is only one minor comment pending in the current PR which is in good shape
   
   I'd be inclined to merge it within 48h unless someone objects. @chunweilei, can you have a final look at the "WEEK" duplication variable discussion when you have some time? I don't have a strong preference, for me it can be left as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org