Re: [PR] fix(native-filters): keep select dropdown below horizontal trigger [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #40125:
URL: https://github.com/apache/superset/pull/40125#issuecomment-4753155103

   @GhostieMostie the core `Select` already passes `dropdownAlign={DROPDOWN_ALIGN_BOTTOM}` (`points: ['tl','bl']`, `offset: [0,4]`), and `{...props}` in `Select.tsx` means your `dropdownAlign` fully replaces it. So, for horizontal bars you're losing the `points` and 4px `offset`, not just disabling `adjustY`. Did you mean `{ ...DROPDOWN_ALIGN_BOTTOM, overflow: { ...DROPDOWN_ALIGN_BOTTOM.overflow, adjustY: false } }`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org