[jira] Commented: (GERONIMO-3618) when redirected via status code 30x, the original query is incorrectly appended to the location

["Sangjin Lee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544553 ] 

Sangjin Lee commented on GERONIMO-3618:
---------------------------------------

Thanks, I see the change.  Just a small note, however...  The local variable query right above the line that was modified is no longer used, and thus can be removed...

> when redirected via status code 30x, the original query is incorrectly appended to the location
> -----------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3618
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3618
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>         Attachments: HttpIoHandler.patch
>
>
> If you're redirected via status code 30x (302, 301, ...), the code that handles following redirects (HttpIoHandler.messageRecieved()) tries to append the original query from the first request to the URL obtained from the Location header of the response.  This is incorrect per HTTP specification.  The spec says the value of the Location header is an absoluteURI which is a full URL that includes the proper query if any: http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30.  The query from the original request should not be part of the second URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.