You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sk...@apache.org on 2005/06/08 09:38:40 UTC
svn commit: r189544 - in
/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters:
ByteArrayConverter.java CharacterArrayConverter.java
DoubleArrayConverter.java FloatArrayConverter.java
IntegerArrayConverter.java LongArrayConverter.java ShortArrayConverter.java
StringArrayConverter.java
Author: skitching
Date: Wed Jun 8 00:38:39 2005
New Revision: 189544
URL: http://svn.apache.org/viewcvs?rev=189544&view=rev
Log:
Make private model variables final, as they are never modified within this
class and cannot be accessed outside it. This also makes it clear that these
static variables are safe even when the code is used via a shared classloader.
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/StringArrayConverter.java
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static byte model[] = new byte[0];
+ private static final byte model[] = new byte[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static char model[] = new char[0];
+ private static final char model[] = new char[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static double model[] = new double[0];
+ private static final double model[] = new double[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static float model[] = new float[0];
+ private static final float model[] = new float[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static int model[] = new int[0];
+ private static final int model[] = new int[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/LongArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/LongArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/LongArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static long model[] = new long[0];
+ private static final long model[] = new long[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,7 +72,7 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static short model[] = new short[0];
+ private static final short model[] = new short[0];
// --------------------------------------------------------- Public Methods
Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/StringArrayConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/StringArrayConverter.java?rev=189544&r1=189543&r2=189544&view=diff
==============================================================================
--- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/StringArrayConverter.java (original)
+++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/converters/StringArrayConverter.java Wed Jun 8 00:38:39 2005
@@ -72,12 +72,12 @@
/**
* <p>Model object for type comparisons.</p>
*/
- private static String model[] = new String[0];
+ private static final String model[] = new String[0];
/**
* <p> Model object for int arrays.</p>
*/
- private static int ints[] = new int[0];
+ private static final int ints[] = new int[0];
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org