You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/07 16:50:31 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3479: ARTEMIS-3163 Experimental support for Netty IO_URING incubator

michaelandrepearce commented on a change in pull request #3479:
URL: https://github.com/apache/activemq-artemis/pull/3479#discussion_r589057140



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
##########
@@ -401,6 +406,21 @@ public ActiveMQThreadFactory run() {
             acceptorType = KQUEUE_ACCEPTOR_TYPE;
 
             logger.debug("Acceptor using native kqueue");
+         } else if (useIoUring && CheckDependencies.isIoUringAvailable()) {

Review comment:
       I would expect io uring to be primary option later with fallback to epoll and then nio, as such maybe this should be first in order of preference. Its off by default but this way going forwards correct preference order would exist.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org