[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4677: [INLONG-4676][Manager] Optimize group init process in Client

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4677:
URL: https://github.com/apache/incubator-inlong/pull/4677#discussion_r898834359


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongGroupImpl.java:
##########
@@ -125,6 +126,13 @@ public void update(InlongGroupInfo originGroupInfo, BaseSortConf sortConf) throw
                 "groupId must be same");
 
         InlongGroupInfo existGroupInfo = managerClient.getGroupInfo(groupId);
+        GroupStatus groupStatus = GroupStatus.forCode(existGroupInfo.getStatus());
+        Date lastModifyTime = existGroupInfo.getModifyTime();
+        Date now = new Date();
+        // If group in TO_BE_APPROVAL state for more than 10s, reject immediately

Review Comment:
   Excuse me, I don't understand why reject in this scenario?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org