You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/10/23 21:09:16 UTC
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2777: [GOBBLIN-921]Make pull/push mode when registering partition to be
configurable
sv2000 commented on a change in pull request #2777: [GOBBLIN-921]Make pull/push mode when registering partition to be configurable
URL: https://github.com/apache/incubator-gobblin/pull/2777#discussion_r338279575
##########
File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -492,7 +499,7 @@ public void addOrAlterPartition(HiveTable table, HivePartition partition) throws
}
}
- private void addOrAlterPartition(IMetaStoreClient client, Table table, HivePartition partition)
+ private void addOrAlterPartitionWithPushMode(IMetaStoreClient client, Table table, HivePartition partition)
Review comment:
Not a blocker for this PR. But if "pull" mode is the way to go, maybe we should remove the "push" mode in future. Same for skipping diff computations on partitions. Not sure if it is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services