You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/24 16:05:01 UTC

[GitHub] [spark] xkrogen commented on a diff in pull request #36973: [SPARK-39575][AVRO] add ByteBuffer#rewind after ByteBuffer#get in Avr…

xkrogen commented on code in PR #36973:
URL: https://github.com/apache/spark/pull/36973#discussion_r906200144


##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala:
##########
@@ -360,4 +362,27 @@ class AvroCatalystDataConversionSuite extends SparkFunSuite
       None,
       new OrderedFilters(Seq(Not(EqualTo("Age", 39))), sqlSchema))
   }
+
+  test("AvroDeserializer with binary type") {
+    val jsonFormatSchema =
+      """
+        |{ "type": "record",
+        |  "name": "record",
+        |  "fields" : [{
+        |    "name": "a",
+        |    "type": {
+        |      "type": "bytes"
+        |    }

Review Comment:
   Why is there a nested type here instead of just `"type": "bytes"` at the top-level?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org