You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/09/19 09:04:46 UTC

[GitHub] [kylin] codecov-io commented on issue #844: KYLIN-4100: call overview function when initing job ctrl in job.js (addendum)

codecov-io commented on issue #844: KYLIN-4100: call overview function when initing job ctrl in job.js (addendum)
URL: https://github.com/apache/kylin/pull/844#issuecomment-533039249
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=h1) Report
   > Merging [#844](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/199bc17e572652b8a8ec8c4f0c6aab1a2359c1ef?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/844/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #844      +/-   ##
   ===========================================
   - Coverage     25.71%   25.7%   -0.01%     
   + Complexity     6125    6124       -1     
   ===========================================
     Files          1400    1400              
     Lines         83729   83729              
     Branches      11740   11740              
   ===========================================
   - Hits          21531   21523       -8     
   - Misses        60126   60138      +12     
   + Partials       2072    2068       -4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/844/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `51.16% <0%> (-3.49%)` | `8% <0%> (ø)` | |
   | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/844/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
   | [...eam/core/storage/columnar/DataSegmentFragment.java](https://codecov.io/gh/apache/kylin/pull/844/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRGF0YVNlZ21lbnRGcmFnbWVudC5qYXZh) | `57.37% <0%> (-1.64%)` | `17% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/844/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/844/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/844/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=footer). Last update [199bc17...4a9cdc2](https://codecov.io/gh/apache/kylin/pull/844?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services