[GitHub] [qpid-proton] DreamPearl commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault

[GitBox <gi...@apache.org>]

DreamPearl commented on pull request #338:
URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-956023315


   @gemmellr @jiridanek Can you please take a look. 
   The cause of segfault was that when we were passing empty vector to connection_options::failoverurls, the current_url was getting set to 0. And on the basis of the value of current_url i.e. 0, it was picking failover_urls instead of reconnect_urls. As it was trying to access failover_urls which was empty, it leads to segfault.
   Deprecated code was able to handle the empty vector, non-deprecated wasn't.
   Alternatively, I tried this: https://github.com/apache/qpid-proton/commit/50d8342c4932da698389dd991760c607de7f79f5 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org