You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/04/22 18:21:52 UTC
[jira] Created: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
OSGi metadata not included in binary only jar
---------------------------------------------
Key: ZOOKEEPER-749
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
Project: Zookeeper
Issue Type: Bug
Components: build
Affects Versions: 3.3.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
Fix For: 3.3.1, 3.4.0
See this JIRA/comment for background:
https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-749:
-------------------------------------
Hadoop Flags: [Reviewed]
+1, patch looks good to me. Tests failing was a quirk of Hudson, as this patch doesn't test code. ant bin-jar works correctly.
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859904#action_12859904 ]
Hadoop QA commented on ZOOKEEPER-749:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442587/ZOOKEEPER-749.patch
against trunk revision 936624.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/66/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/66/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/66/console
This message is automatically generated.
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-749:
-----------------------------------
Status: Patch Available (was: Open)
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-749:
-------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
I just committed this. Thanks Patrick!
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-749:
-----------------------------------
Status: Open (was: Patch Available)
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-749:
-----------------------------------
Attachment: ZOOKEEPER-749.patch
This patch adds the osgi data to the manifest of the maven bin jar.
This patch also includes a fix for ZOOKEEPER-750, plz close that one when you close this.
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in
binary only jar
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-749:
-----------------------------------
Status: Patch Available (was: Open)
> OSGi metadata not included in binary only jar
> ---------------------------------------------
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar (zookeeper-<version>.jar) but not in the binary only
> jar (zookeeper-<version>-bin.jar) which is eventually deployed to the maven repo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.