You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/11 14:49:15 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1062: HDDS-3783. Upload coverage even if tests failed
adoroszlai opened a new pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062
## What changes were proposed in this pull request?
PRs get code coverage feedback from Codecov thanks to changes implemented in HDDS-3726. Codecov needs coverage data for each new revision on `master`. However, _coverage_ check is currently [skipped](https://github.com/apache/hadoop-ozone/runs/759894317?check_suite_focus=true) if any tests fail. This PR proposes to always execute coverage if basic compilation is OK. It still waits for various test runs before execution.
https://issues.apache.org/jira/browse/HDDS-3783
## How was this patch tested?
Tested conditions on simplified workflow file with both:
* successful "compilation": [code](https://github.com/adoroszlai/hadoop-ozone/blob/3639f470b02bd7647b662f7d0435d2e776f92b87/.github/workflows/post-commit.yml), [run](https://github.com/adoroszlai/hadoop-ozone/runs/761754406?check_suite_focus=true)
* and failed "compilation": [code](https://github.com/adoroszlai/hadoop-ozone/blob/5856b413ca5a00c763e318428169588bbbb89d3e/.github/workflows/post-commit.yml), [run](https://github.com/adoroszlai/hadoop-ozone/runs/762117230?check_suite_focus=true)
Real CI ("unfortunately" all tests passed):
https://github.com/adoroszlai/hadoop-ozone/runs/761992786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062#issuecomment-643184139
> I think that's due to using wrong base coverage data.
I am not sure. I thought `codecov` compares the branch with the master instead of `git merge-base`. Seems to be better to have less frequent but good coverage data on the master. With uploading failing test data I can't be sure that the coverage on the sonarcloud is valid or not.
It would be better to understand the problem of codecov and adjust it. Are you sure that this is the missing piece for the codecov?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062#issuecomment-643100736
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=h1) Report
> Merging [#1062](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/f7e95d9b015e764ca93cfe2ccfc96d95160931bc&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1062 +/- ##
============================================
- Coverage 69.48% 69.40% -0.09%
+ Complexity 9110 9109 -1
============================================
Files 961 961
Lines 48132 48127 -5
Branches 4672 4676 +4
============================================
- Hits 33446 33403 -43
- Misses 12468 12508 +40
+ Partials 2218 2216 -2
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/hadoop/hdds/scm/pipeline/Pipeline.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vcGlwZWxpbmUvUGlwZWxpbmUuamF2YQ==) | `85.71% <100.00%> (+0.20%)` | `44.00 <0.00> (+1.00)` | |
| [.../org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT21LZXlJbmZvLmphdmE=) | `86.25% <100.00%> (+0.33%)` | `42.00 <0.00> (+2.00)` | |
| [...adoop/ozone/om/helpers/OmKeyLocationInfoGroup.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT21LZXlMb2NhdGlvbkluZm9Hcm91cC5qYXZh) | `75.60% <100.00%> (+1.25%)` | `12.00 <2.00> (+1.00)` | |
| [...g/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT3pvbmVBY2xVdGlsLmphdmE=) | `81.91% <100.00%> (+1.23%)` | `39.00 <4.00> (+2.00)` | |
| [...adoop/ozone/om/request/key/OMKeyCommitRequest.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yZXF1ZXN0L2tleS9PTUtleUNvbW1pdFJlcXVlc3QuamF2YQ==) | `97.00% <100.00%> (ø)` | `18.00 <0.00> (+1.00)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00% <0.00%> (ø%)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <0.00%> (-10.67%)` | `7.00% <0.00%> (-5.00%)` | |
| [...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9jb2RlYy9TM1NlY3JldFZhbHVlQ29kZWMuamF2YQ==) | `90.90% <0.00%> (-9.10%)` | `3.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9SREJNZXRyaWNzLmphdmE=) | `85.71% <0.00%> (-7.15%)` | `13.00% <0.00%> (-1.00%)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `69.36% <0.00%> (-6.76%)` | `59.00% <0.00%> (-5.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1062/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=footer). Last update [53395a0...26f94fa](https://codecov.io/gh/apache/hadoop-ozone/pull/1062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062#issuecomment-642714217
> I was thinking about the same, but I am afraid if we enable it, we got invalid coverage data. Let's say it-client is failing, at least the failing tests will be missing. For me it seems to be more reliable to upload only the full builds.
I think we get invalid coverage data with the current setup, too. For example #1055 only changes some CSI yaml files, but coverage is said to decrease. I think that's due to using wrong base coverage data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062#issuecomment-642710449
I was thinking about the same, but I am afraid if we enable it, we got invalid coverage data. Let's say it-client is failing, at least the failing tests will be missing. For me it seems to be more reliable to upload only the full builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai closed pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
adoroszlai closed pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062#issuecomment-643626366
Codecov seems to agree with you. ;) It will not compare against commits with failed CI (if it know that CI passed or failed). From the [doc](https://docs.codecov.io/docs/comparing-commits#commits-with-failed-ci):
> If CI fails, one or more of the following assumptions can be made:
> 1. Not all tests were executed; therefore coverage is incomplete.
> 2. Exceptions may call new execution paths, resulting in different coverage metrics.
> 3. A failed test could produce different coverage than the same test ran successfully.
I think for Ozone:
1. is the worst problem, can happen if dependent modules are skipped by Maven due to earlier failure (eg. in `common`).
2. is true even for successful CI ([example](https://codecov.io/gh/apache/hadoop-ozone/compare/bd88eec9fec06a8f8adcbe4d257c5ccaca144f4c...96f07d5c27ba8f2ab9d77df25e10d4cb94489e5f/changes), where [only javadoc was updated](https://github.com/apache/hadoop-ozone/commit/96f07d5c27ba8f2ab9d77df25e10d4cb94489e5f)).
3. is something we should try to fix (eg. split test cases that perform a long series of steps, making assertions all the way).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1062: HDDS-3783. Upload coverage even if tests failed
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1062:
URL: https://github.com/apache/hadoop-ozone/pull/1062#issuecomment-643184526
BTW we can have different rules for codecov / sonarcloud AFAIK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org