You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2024/05/28 07:05:31 UTC

[PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

zhztheplayer opened a new pull request, #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889

   This just simplifies the representation of test report of subcommand `queries-compare`.
   
   Before:
   ```
   ...
   | Query ID| Was Passed| Expected Row Count| Actual Row Count| Baseline Planning Time (Millis)| Planning Time (Millis)| Baseline Query Time (Millis)| Query Time (Millis)| Query Time Variation|
   |       q1|       true|                100|              100|                             967|                    184|                         3530|                2372|               48.82%|
   |       q2|       true|               2513|             2513|                             275|                    182|                         1916|                1516|               26.39%|
   |       q3|       true|                100|              100|                              38|                     54|                          984|                 726|               35.54%|
   |       q4|       true|                100|              100|                             577|                    496|                        11244|                4606|              144.12%|
   |       q5|       true|                100|              100|                             340|                    159|                         2996|                1970|               52.08%|
   ...
   ```
   
   After: 
   
   ```
   ...
   | Query ID| Passed| Row Count (Vanilla -> Gluten)| Planning Time / ms (Vanilla -> Gluten)| Query Time / ms (Vanilla -> Gluten)|  Speedup|
   |       q1|   true|                    100 -> 100|                            1077 -> 259|                        4037 -> 2786|  +44.90%|
   |       q2|   true|                  2513 -> 2513|                             310 -> 186|                        2432 -> 1911|  +27.26%|
   |       q3|   true|                    100 -> 100|                               47 -> 35|                         1162 -> 496| +134.27%|
   |       q4|   true|                    100 -> 100|                             640 -> 534|                       15413 -> 5249| +193.64%|
   |       q5|   true|                    100 -> 100|                             398 -> 166|                        3731 -> 1671| +123.28%|
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2136275977

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Improve test report table rendering [incubator-gluten]

Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer merged PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2134490755

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Improve test report table rendering [incubator-gluten]

Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2136998275

   ===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
   <table border="1" cellpadding="0" cellspacing="0">
                   <tbody>
                       <tr>
                               <td><font color=#000000>query</font></td>
                               <td><font color=#000000>log/native_5889_time.csv</font></td>
                               <td><font color=#000000>log/native_master_05_28_2024_d7374bd8f_time.csv</font></td>
                               <td><font color=#000000>difference</font></td>
                               <td><font color=#000000>percentage</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q1</font></td>
                               <td><font color=#F92663>33.91</font></td>
                               <td><font color=#F92663>34.04</font></td>
                               <td><font color=#F92663>0.132</font></td>
                               <td><font color=#F92663>100.39%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q2</font></td>
                               <td><font color=#6F9915>26.98</font></td>
                               <td><font color=#6F9915>23.62</font></td>
                               <td><font color=#6F9915>-3.354</font></td>
                               <td><font color=#6F9915>87.57%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q3</font></td>
                               <td><font color=#F92663>35.01</font></td>
                               <td><font color=#F92663>36.93</font></td>
                               <td><font color=#F92663>1.923</font></td>
                               <td><font color=#F92663>105.49%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q4</font></td>
                               <td><font color=#6F9915>35.64</font></td>
                               <td><font color=#6F9915>32.10</font></td>
                               <td><font color=#6F9915>-3.542</font></td>
                               <td><font color=#6F9915>90.06%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q5</font></td>
                               <td><font color=#F92663>69.16</font></td>
                               <td><font color=#F92663>69.91</font></td>
                               <td><font color=#F92663>0.748</font></td>
                               <td><font color=#F92663>101.08%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q6</font></td>
                               <td><font color=#F92663>5.87</font></td>
                               <td><font color=#F92663>5.97</font></td>
                               <td><font color=#F92663>0.099</font></td>
                               <td><font color=#F92663>101.69%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q7</font></td>
                               <td><font color=#6F9915>84.46</font></td>
                               <td><font color=#6F9915>80.25</font></td>
                               <td><font color=#6F9915>-4.203</font></td>
                               <td><font color=#6F9915>95.02%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q8</font></td>
                               <td><font color=#F92663>83.63</font></td>
                               <td><font color=#F92663>84.79</font></td>
                               <td><font color=#F92663>1.153</font></td>
                               <td><font color=#F92663>101.38%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q9</font></td>
                               <td><font color=#6F9915>121.83</font></td>
                               <td><font color=#6F9915>121.55</font></td>
                               <td><font color=#6F9915>-0.277</font></td>
                               <td><font color=#6F9915>99.77%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q10</font></td>
                               <td><font color=#6F9915>45.25</font></td>
                               <td><font color=#6F9915>43.64</font></td>
                               <td><font color=#6F9915>-1.608</font></td>
                               <td><font color=#6F9915>96.45%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q11</font></td>
                               <td><font color=#F92663>21.97</font></td>
                               <td><font color=#F92663>22.27</font></td>
                               <td><font color=#F92663>0.297</font></td>
                               <td><font color=#F92663>101.35%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q12</font></td>
                               <td><font color=#F92663>23.99</font></td>
                               <td><font color=#F92663>26.90</font></td>
                               <td><font color=#F92663>2.906</font></td>
                               <td><font color=#F92663>112.11%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q13</font></td>
                               <td><font color=#6F9915>54.40</font></td>
                               <td><font color=#6F9915>52.40</font></td>
                               <td><font color=#6F9915>-1.999</font></td>
                               <td><font color=#6F9915>96.33%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q14</font></td>
                               <td><font color=#F92663>19.02</font></td>
                               <td><font color=#F92663>21.59</font></td>
                               <td><font color=#F92663>2.574</font></td>
                               <td><font color=#F92663>113.53%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q15</font></td>
                               <td><font color=#6F9915>32.60</font></td>
                               <td><font color=#6F9915>31.46</font></td>
                               <td><font color=#6F9915>-1.138</font></td>
                               <td><font color=#6F9915>96.51%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q16</font></td>
                               <td><font color=#6F9915>14.04</font></td>
                               <td><font color=#6F9915>13.97</font></td>
                               <td><font color=#6F9915>-0.064</font></td>
                               <td><font color=#6F9915>99.54%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q17</font></td>
                               <td><font color=#6F9915>104.19</font></td>
                               <td><font color=#6F9915>102.83</font></td>
                               <td><font color=#6F9915>-1.359</font></td>
                               <td><font color=#6F9915>98.70%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q18</font></td>
                               <td><font color=#F92663>144.40</font></td>
                               <td><font color=#F92663>145.92</font></td>
                               <td><font color=#F92663>1.512</font></td>
                               <td><font color=#F92663>101.05%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q19</font></td>
                               <td><font color=#F92663>13.52</font></td>
                               <td><font color=#F92663>14.82</font></td>
                               <td><font color=#F92663>1.298</font></td>
                               <td><font color=#F92663>109.60%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q20</font></td>
                               <td><font color=#F92663>27.38</font></td>
                               <td><font color=#F92663>31.06</font></td>
                               <td><font color=#F92663>3.675</font></td>
                               <td><font color=#F92663>113.42%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q21</font></td>
                               <td><font color=#F92663>257.48</font></td>
                               <td><font color=#F92663>261.69</font></td>
                               <td><font color=#F92663>4.212</font></td>
                               <td><font color=#F92663>101.64%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q22</font></td>
                               <td><font color=#6F9915>13.67</font></td>
                               <td><font color=#6F9915>12.27</font></td>
                               <td><font color=#6F9915>-1.408</font></td>
                               <td><font color=#6F9915>89.70%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>total</font></td>
                               <td><font color=#F92663>1268.40</font></td>
                               <td><font color=#F92663>1269.97</font></td>
                               <td><font color=#F92663>1.576</font></td>
                               <td><font color=#F92663>100.12%</font></td>
                       </tr>
                   </tbody>
               </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2136753589

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2136766678

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2134682832

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5889:
URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2134490412

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICEGJ-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** in the following format?
   
       [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org