[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9619: feat: Add support for custom named log file names for log-rotate plugin

["monkeyDluffy6017 (via GitHub)" <gi...@apache.org>]

monkeyDluffy6017 commented on code in PR #9619:
URL: https://github.com/apache/apisix/pull/9619#discussion_r1221390930


##########
t/plugin/log-rotate3.t:
##########
@@ -132,3 +132,40 @@ start xxxxxx
     }
 --- response_body
 passed
+
+
+=== TEST 4: max_kept effective on differently named compression files

Review Comment:
   Could you add a test case with enable_compression = false because the issue you fixed is like this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org