You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/05 18:19:09 UTC

[GitHub] [maven-jar-plugin] elharo opened a new pull request #15: update minimum Maven version to 3.1.0

elharo opened a new pull request #15:
URL: https://github.com/apache/maven-jar-plugin/pull/15


   @ian-lavallee @rfscholte I can update the minimum Maven version here to 3.1.0, but to do this I have to dd maven-compat back in, at least for tests. Can anyone see how I might do this without maven-compat? When I try I tend to get errors like
   
   WARNING: Error injecting: org.apache.maven.repository.legacy.LegacyRepositorySystem
   java.lang.NoClassDefFoundError: org/sonatype/aether/RepositorySystemSession
   
   That is, something is still asking for Sonatype Aether. It's not immediately obvious to me where/how the binding for RepositorySystemSession is set. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-jar-plugin] elharo merged pull request #15: update minimum Maven version to 3.1.0

Posted by GitBox <gi...@apache.org>.
elharo merged pull request #15:
URL: https://github.com/apache/maven-jar-plugin/pull/15


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-jar-plugin] ian-lavallee commented on pull request #15: update minimum Maven version to 3.1.0

Posted by GitBox <gi...@apache.org>.
ian-lavallee commented on pull request #15:
URL: https://github.com/apache/maven-jar-plugin/pull/15#issuecomment-654400668


   Not sure. When I was making the custom verbose tree plugin I needed to add compat when using the maven-plugin-testing-harness too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-jar-plugin] elharo commented on pull request #15: update minimum Maven version to 3.1.0

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #15:
URL: https://github.com/apache/maven-jar-plugin/pull/15#issuecomment-654797040


   Caused by: org.apache.maven.plugin.PluginContainerException: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-dependency-plugin:3.1.3-SNAPSHOT:analyze: java.lang.IncompatibleClassChangeError: class org.apache.maven.shared.dependency.analyzer.asm.DefaultAnnotationVisitor has interface org.objectweb.asm.AnnotationVisitor as super class


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-jar-plugin] elharo commented on pull request #15: update minimum Maven version to 3.1.0

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #15:
URL: https://github.com/apache/maven-jar-plugin/pull/15#issuecomment-655019946


   Tentatively issue is that maven-compat pulls in an old version of asm:asm instead of org.ow2.asm:asm so both end up in the classpath. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-jar-plugin] rfscholte commented on pull request #15: update minimum Maven version to 3.1.0

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #15:
URL: https://github.com/apache/maven-jar-plugin/pull/15#issuecomment-653922629


   Having maven-compat for test is likely required when it is using maven-plugin-testing-harness. And this one is probably respnsible for pulling in Sonatype Aether. A quick look tells me the testing-harness should be upgraded to 3.1.0 to be Maven 3.1.0 compatible. I'll add it to https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=155749857


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org