You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dcapwell (via GitHub)" <gi...@apache.org> on 2024/06/18 20:31:11 UTC
[PR] Cassandra 19718 [cassandra-accord]
dcapwell opened a new pull request, #99:
URL: https://github.com/apache/cassandra-accord/pull/99
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19718 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #99:
URL: https://github.com/apache/cassandra-accord/pull/99#discussion_r1645025562
##########
accord-core/src/test/java/accord/impl/list/ListStore.java:
##########
@@ -332,7 +332,7 @@ public void fail(Ranges ranges, Throwable failure)
if (!success.isEmpty())
fetchCompletes.add(new FetchComplete(storeId, syncPoint, success));
}
- delegate.fail(ranges, new Throwable());
+ delegate.fail(ranges, new Throwable("Failed Fetch", failure));
Review Comment:
this isn't 100% related to this branch; I am forking different bug fixes from my topology change branch to keep reviews small and easier to understand... when bootstraps fail we loose the "why"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19718 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell merged PR #99:
URL: https://github.com/apache/cassandra-accord/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org