You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/06 13:06:49 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #11626:
[FLINK-16961] Bump Netty 4.X to 4.1.44
tillrohrmann commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
URL: https://github.com/apache/flink/pull/11626#discussion_r404066156
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -934,6 +934,42 @@ under the License.
<hive.version>3.1.1</hive.version>
</properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-metastore</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <!-- Override arrow netty dependency -->
+ <groupId>io.netty</groupId>
+ <artifactId>netty-buffer</artifactId>
+ </exclusion>
+ <exclusion>
+ <!-- Override arrow netty dependency -->
+ <groupId>io.netty</groupId>
+ <artifactId>netty-common</artifactId>
+ </exclusion>
+ </exclusions>
Review comment:
Help me again. Why do we need these exclusions? Wouldn't they be overridden by the explicit Netty dependencies which are closer to the root?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services