You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/04/30 14:07:48 UTC
[GitHub] [incubator-linkis] saLeox opened a new pull request, #2069: Enable the prometheus for monitoring
saLeox opened a new pull request, #2069:
URL: https://github.com/apache/incubator-linkis/pull/2069
### What is the purpose of the change
- Enable the prometheus for monitoring [Ref](https://github.com/apache/incubator-linkis/issues/1656).
- Enable to specify the port range of engine conn(EC) [Ref](https://github.com/apache/incubator-linkis/issues/1749).
### Brief change log
- Enable the prometheus for monitoring;
- Enable to specify the port range of engine conn(EC).
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- Anything that affects deployment: no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: yes
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? [Document](https://github.com/saLeox/incubator-linkis-website/blob/prometheus-branch/docs/deployment/involve_prometheus_into_linkis.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2069: Enable the prometheus for monitoring
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2069:
URL: https://github.com/apache/incubator-linkis/pull/2069#issuecomment-1113997843
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2069](https://codecov.io/gh/apache/incubator-linkis/pull/2069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9b1be2) into [dev-1.1.3](https://codecov.io/gh/apache/incubator-linkis/commit/9e336ccbb366ac3f88f7080a672edb67c5fab482?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e336cc) will **decrease** coverage by `1.93%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## dev-1.1.3 #2069 +/- ##
===============================================
- Coverage 18.69% 16.76% -1.94%
+ Complexity 715 629 -86
===============================================
Files 344 334 -10
Lines 10764 10447 -317
Branches 1625 1572 -53
===============================================
- Hits 2012 1751 -261
+ Misses 8551 8540 -11
+ Partials 201 156 -45
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/linkis/common/conf/Configuration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vY29uZi9Db25maWd1cmF0aW9uLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...s/governance/common/conf/GovernaceCommonConf.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL2dvdmVybmFuY2UvY29tbW9uL2NvbmYvR292ZXJuYWNlQ29tbW9uQ29uZi5zY2FsYQ==) | `94.11% <100.00%> (+0.36%)` | :arrow_up: |
| [...he/linkis/cli/core/exception/CommandException.java](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NsaS9jb3JlL2V4Y2VwdGlvbi9Db21tYW5kRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../linkis/cli/core/exception/error/CommonErrMsg.java](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NsaS9jb3JlL2V4Y2VwdGlvbi9lcnJvci9Db21tb25FcnJNc2cuamF2YQ==) | `0.00% <0.00%> (-93.94%)` | :arrow_down: |
| [...ava/org/apache/linkis/cli/core/utils/LogUtils.java](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NsaS9jb3JlL3V0aWxzL0xvZ1V0aWxzLmphdmE=) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...ore/exception/handler/CommandExceptionHandler.java](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NsaS9jb3JlL2V4Y2VwdGlvbi9oYW5kbGVyL0NvbW1hbmRFeGNlcHRpb25IYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-54.55%)` | :arrow_down: |
| [...ore/exception/handler/DefaultExceptionHandler.java](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NsaS9jb3JlL2V4Y2VwdGlvbi9oYW5kbGVyL0RlZmF1bHRFeGNlcHRpb25IYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-31.43%)` | :arrow_down: |
| [...g/apache/linkis/common/conf/BDPConfiguration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vY29uZi9CRFBDb25maWd1cmF0aW9uLnNjYWxh) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...ala/org/apache/linkis/common/conf/CommonVars.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vY29uZi9Db21tb25WYXJzLnNjYWxh) | `0.00% <0.00%> (-16.67%)` | :arrow_down: |
| [...li/core/interactor/command/CmdTemplateFactory.java](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NsaS9jb3JlL2ludGVyYWN0b3IvY29tbWFuZC9DbWRUZW1wbGF0ZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-15.39%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-linkis/pull/2069/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2069?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9e336cc...b9b1be2](https://codecov.io/gh/apache/incubator-linkis/pull/2069?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #2069: Enable the prometheus for monitoring
Posted by GitBox <gi...@apache.org>.
casionone merged PR #2069:
URL: https://github.com/apache/incubator-linkis/pull/2069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2069: Enable the prometheus for monitoring
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2069:
URL: https://github.com/apache/incubator-linkis/pull/2069#discussion_r866814098
##########
linkis-computation-governance/linkis-engineconn-manager/linkis-engineconn-manager-core/src/main/scala/org/apache/linkis/ecm/core/launch/ProcessEngineConnLaunch.scala:
##########
@@ -99,6 +101,32 @@ trait ProcessEngineConnLaunch extends EngineConnLaunch with Logging {
Utils.tryFinally(socket.getLocalPort)(IOUtils.closeQuietly(socket))
}
+ private def findAvailPortByRange(): Int = {
+ val separator = ":"
Review Comment:
The new method `findAvailPortByRange()` needs to add the corresponding unit test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2069: Enable the prometheus for monitoring
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2069:
URL: https://github.com/apache/incubator-linkis/pull/2069#discussion_r866798938
##########
linkis-computation-governance/linkis-engineconn-manager/linkis-engineconn-manager-core/src/main/scala/org/apache/linkis/ecm/core/launch/ProcessEngineConnLaunch.scala:
##########
@@ -99,6 +101,32 @@ trait ProcessEngineConnLaunch extends EngineConnLaunch with Logging {
Utils.tryFinally(socket.getLocalPort)(IOUtils.closeQuietly(socket))
}
+ private def findAvailPortByRange(): Int = {
+ val separator = ":"
Review Comment:
Maybe it's more accurate to use `-` as a separator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org