You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/24 06:13:13 UTC
[GitHub] [skywalking] wankai123 commented on a change in pull request #7367: Add Thread and ClassLoader Metrics for the self-observability
wankai123 commented on a change in pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#discussion_r675954651
##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/self-observability.yml
##########
@@ -184,6 +184,42 @@ templates:
"metricLabels": "50,70,90,99",
"labelsIndex": "50,70,90,99",
"unit": "Millisecond"
+ },
+ {
+ "width": 3,
+ "title": "Thread Count",
+ "height": "200",
+ "entityType": "ServiceInstance",
+ "independentSelector": false,
+ "metricType": "REGULAR_VALUE",
+ "metricName": "meter_oap_instance_jvm_thread_live_count,meter_oap_instance_jvm_thread_daemon_count,meter_oap_instance_jvm_thread_peak_count",
+ "queryMetricType": "readMetricsValues",
+ "chartType": "ChartLine",
+ "unit": "Per Minute"
Review comment:
what does the unit `Per Minute` mean? If you want to get the time duration metric you should use like `rate('PT1M')` or `increase('PT1M')` in the expressions.
##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/self-observability.yml
##########
@@ -184,6 +184,42 @@ templates:
"metricLabels": "50,70,90,99",
"labelsIndex": "50,70,90,99",
"unit": "Millisecond"
+ },
+ {
+ "width": 3,
+ "title": "Thread Count",
+ "height": "200",
+ "entityType": "ServiceInstance",
+ "independentSelector": false,
+ "metricType": "REGULAR_VALUE",
+ "metricName": "meter_oap_instance_jvm_thread_live_count,meter_oap_instance_jvm_thread_daemon_count,meter_oap_instance_jvm_thread_peak_count",
+ "queryMetricType": "readMetricsValues",
+ "chartType": "ChartLine",
+ "unit": "Per Minute"
+ },
+ {
+ "width": 3,
+ "title": "Thread State Count",
+ "height": "200",
+ "entityType": "ServiceInstance",
+ "independentSelector": false,
+ "metricType": "REGULAR_VALUE",
+ "metricName": "meter_oap_instance_jvm_thread_runnable_state_thread_count,meter_oap_instance_jvm_thread_blocked_state_thread_count,meter_oap_instance_jvm_thread_waiting_state_thread_count,meter_oap_instance_jvm_thread_timed_waiting_state_thread_count",
+ "queryMetricType": "readMetricsValues",
+ "chartType": "ChartBar",
+ "unit": "Per Minute"
Review comment:
also here.
##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/self-observability.yml
##########
@@ -184,6 +184,42 @@ templates:
"metricLabels": "50,70,90,99",
"labelsIndex": "50,70,90,99",
"unit": "Millisecond"
+ },
+ {
+ "width": 3,
+ "title": "Thread Count",
+ "height": "200",
+ "entityType": "ServiceInstance",
+ "independentSelector": false,
+ "metricType": "REGULAR_VALUE",
+ "metricName": "meter_oap_instance_jvm_thread_live_count,meter_oap_instance_jvm_thread_daemon_count,meter_oap_instance_jvm_thread_peak_count",
+ "queryMetricType": "readMetricsValues",
+ "chartType": "ChartLine",
+ "unit": "Per Minute"
+ },
+ {
+ "width": 3,
+ "title": "Thread State Count",
+ "height": "200",
+ "entityType": "ServiceInstance",
+ "independentSelector": false,
+ "metricType": "REGULAR_VALUE",
+ "metricName": "meter_oap_instance_jvm_thread_runnable_state_thread_count,meter_oap_instance_jvm_thread_blocked_state_thread_count,meter_oap_instance_jvm_thread_waiting_state_thread_count,meter_oap_instance_jvm_thread_timed_waiting_state_thread_count",
+ "queryMetricType": "readMetricsValues",
+ "chartType": "ChartBar",
+ "unit": "Per Minute"
+ },
+ {
+ "width": 3,
+ "title": "Class Count",
+ "height": "200",
+ "entityType": "ServiceInstance",
+ "independentSelector": false,
+ "metricType": "REGULAR_VALUE",
+ "metricName": "meter_oap_instance_jvm_class_loaded_class_count,meter_oap_instance_jvm_class_total_unloaded_class_count,meter_oap_instance_jvm_class_total_loaded_class_count",
+ "queryMetricType": "readMetricsValues",
+ "chartType": "ChartArea",
+ "unit": "Per Minute"
Review comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org