You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sandecho <gi...@git.apache.org> on 2018/02/08 17:15:58 UTC
[GitHub] spark pull request #20549: Add more binary classification metrics to BinaryC...
GitHub user sandecho opened a pull request:
https://github.com/apache/spark/pull/20549
Add more binary classification metrics to BinaryClassificationMetrics
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandecho/spark new_branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20549
----
commit 9f33d677586043fe7c75ac1930c51c138f281a49
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T16:49:13Z
Add more binary classification metrics to BinaryClassificationMetrics
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
I will generate the patch once again and submit
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20549
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: Add more binary classification metrics to BinaryClassifi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20549
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: Add more binary classification metrics to BinaryC...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho closed the pull request at:
https://github.com/apache/spark/pull/20549
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20549
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
Can you please run the test again?
[SPARK-JIRA-18844.zip](https://github.com/apache/spark/files/1724418/SPARK-JIRA-18844.zip)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20549
I'm not sure there was support to make this change. The value of these additional metrics is pretty marginal.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20549
**[Test build #4089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4089/testReport)** for PR 20549 at commit [`d7144f6`](https://github.com/apache/spark/commit/d7144f63a99e575d5c996fd7919bdbe44266620f).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20549
Usually I would close them. I often get push-back from those who complain that someone someday might work on it or offer a more compelling take on it. I didn't feel strongly about this, but would not merge it. I erred on the side of leaving it open for any other committer to support it though, but, I don't see that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
Then why was the status of JIRA left open from so many days. It was supposed to be closed earlier.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: SPARK-18844[MLLIB] Add more binary classification...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho closed the pull request at:
https://github.com/apache/spark/pull/20549
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: Add more binary classification metrics to BinaryC...
Posted by sandecho <gi...@git.apache.org>.
GitHub user sandecho reopened a pull request:
https://github.com/apache/spark/pull/20549
Add more binary classification metrics to BinaryClassificationMetrics
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandecho/spark new_branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20549
----
commit 9f33d677586043fe7c75ac1930c51c138f281a49
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T16:49:13Z
Add more binary classification metrics to BinaryClassificationMetrics
commit d7144f63a99e575d5c996fd7919bdbe44266620f
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T17:20:52Z
SPARK-18844
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
ok to test. Jenkins, add to whitelist.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20549
**[Test build #4089 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4089/testReport)** for PR 20549 at commit [`d7144f6`](https://github.com/apache/spark/commit/d7144f63a99e575d5c996fd7919bdbe44266620f).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
As a first time contributor and a novice on it, I would submit the final patch and leave it up to you. You can merge it or leave it. I will close the pull request after that, whether patch is accepted or not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: SPARK-18844[MLLIB] Add more binary classification...
Posted by sandecho <gi...@git.apache.org>.
GitHub user sandecho reopened a pull request:
https://github.com/apache/spark/pull/20549
SPARK-18844[MLLIB] Add more binary classification metrics to BinaryClassificationMetrics
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandecho/spark new_branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20549
----
commit 9f33d677586043fe7c75ac1930c51c138f281a49
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T16:49:13Z
Add more binary classification metrics to BinaryClassificationMetrics
commit d7144f63a99e575d5c996fd7919bdbe44266620f
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T17:20:52Z
SPARK-18844
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
[SPARK-18844.zip](https://github.com/apache/spark/files/1708136/SPARK-18844.zip)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20549
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20549
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20549
As I say, I don't think this would be merged anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
Srowen: Will the result of the test not be posted?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20549
This doesn't even merge, so tests can't run.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: SPARK-18844[MLLIB] Add more binary classification...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho closed the pull request at:
https://github.com/apache/spark/pull/20549
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: SPARK-18844[MLLIB] Add more binary classification...
Posted by sandecho <gi...@git.apache.org>.
GitHub user sandecho reopened a pull request:
https://github.com/apache/spark/pull/20549
SPARK-18844[MLLIB] Add more binary classification metrics to BinaryClassificationMetrics
## What changes were proposed in this pull request?
In this PR, more binary classification metrics has been added to BinaryClassificationMetrics as mentioned in SPARK-18844
## How was this patch tested?
By running existing unit test
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandecho/spark new_branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20549
----
commit 9f33d677586043fe7c75ac1930c51c138f281a49
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T16:49:13Z
Add more binary classification metrics to BinaryClassificationMetrics
commit d7144f63a99e575d5c996fd7919bdbe44266620f
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-08T17:20:52Z
SPARK-18844
commit 981a1c14892e7e458e1492b3fdb6c77bbb35a0fb
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-11T17:18:01Z
SPARK JIRA 18844
commit 47e56658b83b4c2763f636ba025bdfa39a635960
Author: Sandeep Kumar Choudhary <ts...@...>
Date: 2018-02-14T14:38:06Z
SPARK JIRA 18844
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20549
I can run the tests for you, but, not sure this would be merged even if it passes. (You won't have permissions to let the tests run or whitelist yourself)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20549: Add more binary classification metrics to BinaryC...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho closed the pull request at:
https://github.com/apache/spark/pull/20549
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Posted by sandecho <gi...@git.apache.org>.
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
I have committed the changes. Can you please run the test?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org