You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2014/04/10 18:00:19 UTC

[jira] [Resolved] (IO-437) Make IOUtils.EOF public and reuse it in various classes

     [ https://issues.apache.org/jira/browse/IO-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory resolved IO-437.
-----------------------------

    Resolution: Fixed

{noformat}
commit -m "<action issue="IO-437" dev="ggregory" type="add">..." (17 paths specified)
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/changes/changes.xml
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/EndianUtils.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/AutoCloseInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/CharSequenceInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/CharSequenceReader.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/ClosedInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/CountingInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/DemuxInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/NullInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/NullReader.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/ProxyInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/ProxyReader.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/ReaderInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/SwappedDataInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/Tailer.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/input/TeeInputStream.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/io/src/main/java/org/apache/commons/io/output/ByteArrayOutputStream.java
    Transmitting file data ...
    Committed revision 1586350.
{noformat}

These are the obvious changes.

Not changed are:

More places where -1 is used as a magic number but it is with different semantics: index not found.

There is another classes which seems to use -1 for both EOF and index not found.

> Make IOUtils.EOF public and reuse it in various classes
> -------------------------------------------------------
>
>                 Key: IO-437
>                 URL: https://issues.apache.org/jira/browse/IO-437
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.4
>         Environment: Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T12:37:52-05:00)
> Maven home: C:\Java\apache-maven-3.2.1\bin\..
> Java version: 1.7.0_51, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_51\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)