You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/10 04:37:06 UTC
[GitHub] [incubator-nuttx] FASTSHIFT opened a new pull request, #7268: boards: adapt LVGL v8 defconfig
FASTSHIFT opened a new pull request, #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268
Signed-off-by: pengyiqiang <pe...@xiaomi.com>
## Summary
Adapt to LVGL v8 update: https://github.com/apache/incubator-nuttx-apps/pull/1341
## Impact
LVGL related configuration may not work properly.
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] FASTSHIFT commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
FASTSHIFT commented on PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1281844948
@gustavonihei
Can you help test other ESP32 boards? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] FASTSHIFT commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
FASTSHIFT commented on PR #7268:
URL: https://github.com/apache/nuttx/pull/7268#issuecomment-1329126441
@tmedicci
Do you agree to turn off the font:
`CONFIG_LV_FONT_MONTSERRAT_12`
`CONFIG_LV_FONT_MONTSERRAT_18`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
tmedicci commented on PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1298767920
> @tmedicci @gustavonihei Is there anything else we need to modify? Can we start merging this PR :)
It isn't a block from my side, but I still see a warning regarding the framebuffer usage, please check https://github.com/apache/incubator-nuttx-apps/pull/1341/files#diff-2017a1909697a8fc95f0082144b1c6ef91522530ba90c8cd37caa318a5a346ec
I'd say that it's important to double-check the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
acassis merged PR #7268:
URL: https://github.com/apache/nuttx/pull/7268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r991506441
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lvgl/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_DEV=y
CONFIG_LCD_ILI9341=y
CONFIG_LCD_ILI9341_IFACE0=y
CONFIG_LV_COLOR_16_SWAP=y
-CONFIG_LV_DPI=125
+CONFIG_LV_MEM_CUSTOM=y
+CONFIG_LV_PORT_USE_LCDDEV=y
+CONFIG_LV_PORT_USE_TOUCHPAD=y
Review Comment:
ESP-WROVER-KIT does not provide input support with LVGL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
tmedicci commented on PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1283933784
> > @gustavonihei Can you help test other ESP32 boards? :)
>
> I have just the ESP-WROVER-KIT here, I believe @tmedicci could help testing with the `ttgo_t_display_esp32` platform.
I was able to test on _ttgo_t_display_esp32_. `ttgo_t_display_esp32:lvgl_fb` worked successfully. `ttgo_t_display_esp32:lvgl_lcd` fails to build because it lacks a parameters I've commented on code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r991573485
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lvgl/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_DEV=y
CONFIG_LCD_ILI9341=y
CONFIG_LCD_ILI9341_IFACE0=y
CONFIG_LV_COLOR_16_SWAP=y
-CONFIG_LV_DPI=125
+CONFIG_LV_MEM_CUSTOM=y
+CONFIG_LV_PORT_USE_LCDDEV=y
+CONFIG_LV_PORT_USE_TOUCHPAD=y
Review Comment:
With the patch from #7277, I managed to execute the Widgets demo on the ESP-WROVER-KIT development board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] FASTSHIFT commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
FASTSHIFT commented on PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1298714538
@tmedicci @gustavonihei
Is there anything else we need to modify? Can we start merging this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
tmedicci commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r999377055
##########
boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_lcd/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_ST7789_XOFFSET=53
CONFIG_LCD_ST7789_XRES=135
CONFIG_LCD_ST7789_YOFFSET=40
CONFIG_LCD_ST7789_YRES=240
-CONFIG_LV_HOR_RES=135
+CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y
Review Comment:
Please, add `CONFIG_LV_MEM_CUSTOM` from the `menuconfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r991573793
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lvgl/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_DEV=y
CONFIG_LCD_ILI9341=y
CONFIG_LCD_ILI9341_IFACE0=y
CONFIG_LV_COLOR_16_SWAP=y
-CONFIG_LV_DPI=125
+CONFIG_LV_MEM_CUSTOM=y
+CONFIG_LV_PORT_USE_LCDDEV=y
+CONFIG_LV_PORT_USE_TOUCHPAD=y
Review Comment:
`CONFIG_LV_PORT_USE_TOUCHPAD` still needs to be removed from the defconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] FASTSHIFT commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
FASTSHIFT commented on PR #7268:
URL: https://github.com/apache/nuttx/pull/7268#issuecomment-1328734479
> > @tmedicci @gustavonihei Is there anything else we need to modify? Can we start merging this PR :)
>
> It isn't a block from my side, but I still see a warning regarding the framebuffer usage, please check my last comment on [apache/nuttx-apps#1341](https://github.com/apache/nuttx-apps/pull/1341)
>
> I'd say that it's important to double-check the implementation.
Sorry it took so long to reply.
Is the framebuffer warning `"fbmem2 is incorrect"` this one? I changed this to `INFO` level because this is designed to accommodate dual framebuffers with non-contiguous addresses. For single framebuffer devices, this is not required.
`CONFIG_LV_FONT_MONTSERRAT_12`
`CONFIG_LV_FONT_MONTSERRAT_18`
I don't think it's necessary, LVGL will automatically choose the default font, it doesn't affect the demo effect, turning off the non-necessary fonts can save FLASH space, I would like to turn them off again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r991510134
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lvgl/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_DEV=y
CONFIG_LCD_ILI9341=y
CONFIG_LCD_ILI9341_IFACE0=y
CONFIG_LV_COLOR_16_SWAP=y
-CONFIG_LV_DPI=125
+CONFIG_LV_MEM_CUSTOM=y
+CONFIG_LV_PORT_USE_LCDDEV=y
+CONFIG_LV_PORT_USE_TOUCHPAD=y
Review Comment:
@gustavonihei could you verify the change work on ESP board? Since we can just very the change on stm32 and internal board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1283096658
> @gustavonihei Can you help test other ESP32 boards? :)
I have just the ESP-WROVER-KIT here, I believe @tmedicci could help testing with the `ttgo_t_display_esp32` platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
tmedicci commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r999510752
##########
boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_lcd/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_ST7789_XOFFSET=53
CONFIG_LCD_ST7789_XRES=135
CONFIG_LCD_ST7789_YOFFSET=40
CONFIG_LCD_ST7789_YRES=240
-CONFIG_LV_HOR_RES=135
+CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y
Review Comment:
I think the slideshow example was removed, so that could be removed.
##########
boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_fb/defconfig:
##########
@@ -43,7 +43,13 @@ CONFIG_LCD_ST7789_XOFFSET=53
CONFIG_LCD_ST7789_XRES=135
CONFIG_LCD_ST7789_YOFFSET=40
CONFIG_LCD_ST7789_YRES=240
-CONFIG_LV_HOR_RES=135
+CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y
Review Comment:
I think the slideshow example was removed, so that could be removed.
##########
boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_lcd/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_ST7789_XOFFSET=53
CONFIG_LCD_ST7789_XRES=135
CONFIG_LCD_ST7789_YOFFSET=40
CONFIG_LCD_ST7789_YRES=240
-CONFIG_LV_HOR_RES=135
+CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y
Review Comment:
Please, add (from `menuconfig`) the following flags:
1. `CONFIG_LV_FONT_MONTSERRAT_12`
2. `CONFIG_LV_FONT_MONTSERRAT_18`
##########
boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_fb/defconfig:
##########
@@ -43,7 +43,13 @@ CONFIG_LCD_ST7789_XOFFSET=53
CONFIG_LCD_ST7789_XRES=135
CONFIG_LCD_ST7789_YOFFSET=40
CONFIG_LCD_ST7789_YRES=240
-CONFIG_LV_HOR_RES=135
+CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y
+CONFIG_LV_MEM_CUSTOM=y
Review Comment:
Please, add (from `menuconfig`) the following flags:
1. `CONFIG_LV_FONT_MONTSERRAT_12`
2. `CONFIG_LV_FONT_MONTSERRAT_18`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7268:
URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r991511690
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lvgl/defconfig:
##########
@@ -42,7 +42,13 @@ CONFIG_LCD_DEV=y
CONFIG_LCD_ILI9341=y
CONFIG_LCD_ILI9341_IFACE0=y
CONFIG_LV_COLOR_16_SWAP=y
-CONFIG_LV_DPI=125
+CONFIG_LV_MEM_CUSTOM=y
+CONFIG_LV_PORT_USE_LCDDEV=y
+CONFIG_LV_PORT_USE_TOUCHPAD=y
Review Comment:
Sure, I am testing it right now.
But so far `lvgldemo widgets` is failing to run:
```
nsh> lvgldemo widgets
[LVGL] [Warn] (5.340, +5340) lv_demo_widgets: LV_FONT_MONTSERRAT_18 is not enabled for the widgets demo. Using LV_FONT_DEFAULT instead. (in lv_demo_widgets.c line #138)
[LVGL] [Warn] (5.340, +0) lv_demo_widgets: LV_FONT_MONTSERRAT_12 is not enabled for the widgets demo. Using LV_FONT_DEFAULT instead. (in lv_demo_widgets.c line #143)
[LVGL] [Error] (5.860, +520) lcddev_update_thread: ioctl(LCDDEVIO_PUTAREA) failed: 22 (in lv_port_lcddev.c line #104)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] FASTSHIFT commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
FASTSHIFT commented on PR #7268:
URL: https://github.com/apache/nuttx/pull/7268#issuecomment-1328742299
> > @tmedicci @gustavonihei Is there anything else we need to modify? Can we start merging this PR :)
>
> It isn't a block from my side, but I still see a warning regarding the framebuffer usage, please check my last comment on [apache/nuttx-apps#1341](https://github.com/apache/nuttx-apps/pull/1341)
>
> I'd say that it's important to double-check the implementation.
I don't seem to find any relevant comments on https://github.com/apache/nuttx-apps/pull/1341, can you try again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on pull request #7268: boards: adapt LVGL v8 defconfig
Posted by GitBox <gi...@apache.org>.
tmedicci commented on PR #7268:
URL: https://github.com/apache/nuttx/pull/7268#issuecomment-1329231895
> @tmedicci Do you agree to turn off the font: `CONFIG_LV_FONT_MONTSERRAT_12` `CONFIG_LV_FONT_MONTSERRAT_18`
I see no problems turning off the fonts besides the warning. Particularly, I'd keep them enabled for that defconfig, but you can decide about it ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org