[GitHub] [superset] ofekisr commented on pull request #17893: refactor: examples data loading for tests

[GitBox <gi...@apache.org>]

ofekisr commented on pull request #17893:
URL: https://github.com/apache/superset/pull/17893#issuecomment-1009895630


   @villebro @amitmiran137 
   I added tests for common
   I changed to use "..."
   
   regarding the abstractions: this is how I'm coding ... design to interfaces
   the one who uses the generator should not aware of how it generates (decouple implementations details)
   Why do you fear using abstractions? 
   the singleton is inside the abstract class so the client is only aware of the API.  the concrete details of how the generator is built are encapsulated, but there is a way to change the implementations if required and should be done in separate setup file
   
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org