You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Abhishek Shivanna (Jira)" <ji...@apache.org> on 2020/05/27 18:40:00 UTC
[jira] [Updated] (SAMZA-2532) Refactor MetricsSnapshotReporter to
be more stable and extendable
[ https://issues.apache.org/jira/browse/SAMZA-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhishek Shivanna updated SAMZA-2532:
-------------------------------------
Description:
MetricsSnapshotReporter does not handle runtime exceptions that can be thrown from withing its run() method. Not handling all exceptions results in the Executor to stop scheduling future executions.
Also, the MetricsSnapshotReporter and its factory are not easily extendable - as the entire implementation exists in a giant method. If we were to break this method down into smaller overridable chunks, it would help reuse most parts of the code while allowing sub-classes to customize the reporting.
was:
MetricsSnapshotReporter does not handle runtime exceptions that can be thrown from withing its run() method. Not handling all exceptions results in the Executor to stop scheduling future executions.
Also, the MetricsSnapshotReporter today is not easily extendable - as the entire implementation exists in a giant run() method. If we were to break this method down into smaller overridable chunks, it would help reuse most parts of the code while allowing sub-classes to customize the reporting.
> Refactor MetricsSnapshotReporter to be more stable and extendable
> -----------------------------------------------------------------
>
> Key: SAMZA-2532
> URL: https://issues.apache.org/jira/browse/SAMZA-2532
> Project: Samza
> Issue Type: Improvement
> Reporter: Abhishek Shivanna
> Assignee: Abhishek Shivanna
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> MetricsSnapshotReporter does not handle runtime exceptions that can be thrown from withing its run() method. Not handling all exceptions results in the Executor to stop scheduling future executions.
> Also, the MetricsSnapshotReporter and its factory are not easily extendable - as the entire implementation exists in a giant method. If we were to break this method down into smaller overridable chunks, it would help reuse most parts of the code while allowing sub-classes to customize the reporting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)