You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/09/19 07:51:47 UTC
Review Request 25820: CLOUDSTACK-7575: Improve performance of
cleanString method in StringUtils
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25820/
-----------------------------------------------------------
Review request for cloudstack and Devdeep Singh.
Summary (updated)
-----------------
CLOUDSTACK-7575: Improve performance of cleanString method in StringUtils
Repository: cloudstack-git
Description (updated)
-------
We are using two regular expressions to clean sensitive data from logged string. One regular expression is cleaning from middle while other from end. This patch combines those two regular expressions in one regular expression
Diffs (updated)
-----
utils/src/com/cloud/utils/StringUtils.java 7014e5c
Diff: https://reviews.apache.org/r/25820/diff/
Testing (updated)
-------
tested the strings are cleaned up properly of passwords after the changes
Thanks,
Anshul Gangwar
Re: Review Request 25820: CLOUDSTACK-7575: Improve performance of
cleanString method in StringUtils
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25820/#review54658
-----------------------------------------------------------
Ship it!
Committed changes in 7972f53c8d35b78bd27cbd2c8bb1beb763b69c00
- Devdeep Singh
On Sept. 19, 2014, 5:51 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25820/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 5:51 a.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We are using two regular expressions to clean sensitive data from logged string. One regular expression is cleaning from middle while other from end. This patch combines those two regular expressions in one regular expression
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 7014e5c
>
> Diff: https://reviews.apache.org/r/25820/diff/
>
>
> Testing
> -------
>
> tested the strings are cleaned up properly of passwords after the changes
>
>
> Thanks,
>
> Anshul Gangwar
>
>