You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by neoremind <gi...@git.apache.org> on 2018/03/05 09:01:43 UTC
[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...
GitHub user neoremind opened a pull request:
https://github.com/apache/flink/pull/5633
[FLINK-8857] [Hbase] Avoid HBase connector read example throwing exception at the end
## What is the purpose of the change
*This pull request fixes problem of HBase read example throwing exception at the end of the program execution.*
## Brief change log
- *Update example `flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java` by removing the part causing the problem.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neoremind/flink FLINK-8857
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5633
----
commit 97c009a4d2308ad1da5629f9653bed9af352a8f7
Author: neoremind <xu...@...>
Date: 2018-03-05T08:50:37Z
Avoid hbase connector read example throwing exception at the end.
----
---
[GitHub] flink issue #5633: [FLINK-8857] [Hbase] Avoid HBase connector read example t...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5633
merging.
---
[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...
Posted by neoremind <gi...@git.apache.org>.
Github user neoremind commented on a diff in the pull request:
https://github.com/apache/flink/pull/5633#discussion_r172125701
--- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java ---
@@ -86,8 +86,8 @@ public boolean filter(Tuple2<String, String> t) throws Exception {
hbaseDs.print();
- // kick off execution.
- env.execute();
+ // kick off execution is not needed.
+ // env.execute();
--- End diff --
Done.
---
[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5633#discussion_r172124498
--- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java ---
@@ -86,8 +86,8 @@ public boolean filter(Tuple2<String, String> t) throws Exception {
hbaseDs.print();
- // kick off execution.
- env.execute();
+ // kick off execution is not needed.
+ // env.execute();
--- End diff --
you can add another commit that removes the code
---
[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...
Posted by neoremind <gi...@git.apache.org>.
Github user neoremind commented on a diff in the pull request:
https://github.com/apache/flink/pull/5633#discussion_r172122738
--- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java ---
@@ -86,8 +86,8 @@ public boolean filter(Tuple2<String, String> t) throws Exception {
hbaseDs.print();
- // kick off execution.
- env.execute();
+ // kick off execution is not needed.
+ // env.execute();
--- End diff --
Cool! So should I close this PR?
---
[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5633#discussion_r172122162
--- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java ---
@@ -86,8 +86,8 @@ public boolean filter(Tuple2<String, String> t) throws Exception {
hbaseDs.print();
- // kick off execution.
- env.execute();
+ // kick off execution is not needed.
+ // env.execute();
--- End diff --
I'd just remove it.
---
[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5633
---