[GitHub] [accumulo] ctubbsii commented on issue #2635: Prevent multiple creation of multiple PropStore instances.

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #2635:
URL: https://github.com/apache/accumulo/issues/2635#issuecomment-1158055516

   I don't think this is a problem, as long as the PropStore in the ServerContext is lazily initialized, which can be done by Suppliers.memoize, like other fields in ServerContext. I also noticed a related issue: we're creating two SystemConfiguration objects... one is created by ServerConfigurationFactory, and another is directly created in ServerContext. The latter should be removed, so only ServerConfigurationFactory is responsible for creating it. I don't know if there's any chicken-egg problems that this was trying to workaround, but if all the ITs pass, I would expect this to not be a problem getting rid of the latter one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org