You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 11:46:14 UTC
[GitHub] [doris] zenoyang opened a new pull request, #13836: [fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy
zenoyang opened a new pull request, #13836:
URL: https://github.com/apache/doris/pull/13836
# Proposed changes
Issue Number: close #xxx
`BackendServiceProxy.getInstance()` uses the round robin strategy to obtain the proxy, so when the current RPC request is abnormal, the proxy removed by `BackendServiceProxy.getInstance().removeProxy(...)` is not an abnormal proxy.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13836: [fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13836:
URL: https://github.com/apache/doris/pull/13836#issuecomment-1297431254
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.02 seconds
load time: 573 seconds
storage size: 17154644817 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221031173018_clickbench_pr_36673.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13836: [fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13836:
URL: https://github.com/apache/doris/pull/13836#discussion_r1010147948
##########
fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java:
##########
@@ -64,7 +64,7 @@ private static class Holder {
}
static BackendServiceProxy get() {
- return proxies[count.addAndGet(1) % PROXY_NUM];
+ return proxies[Math.abs(count.addAndGet(1) % PROXY_NUM)];
Review Comment:
Why need `Math.abs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13836: [fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13836:
URL: https://github.com/apache/doris/pull/13836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zenoyang commented on a diff in pull request #13836: [fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy
Posted by GitBox <gi...@apache.org>.
zenoyang commented on code in PR #13836:
URL: https://github.com/apache/doris/pull/13836#discussion_r1010212824
##########
fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java:
##########
@@ -64,7 +64,7 @@ private static class Holder {
}
static BackendServiceProxy get() {
- return proxies[count.addAndGet(1) % PROXY_NUM];
+ return proxies[Math.abs(count.addAndGet(1) % PROXY_NUM)];
Review Comment:
If `count` exceeds the maximum value of `Integer`, the result of the remainder will be negative, which will cause an `IndexOutOfBoundsException` error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org