You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rfung777 (via GitHub)" <gi...@apache.org> on 2024/08/04 18:53:57 UTC
[PR] Support execution in Windows using Local File System and NFS [iceberg-python]
rfung777 opened a new pull request, #996:
URL: https://github.com/apache/iceberg-python/pull/996
When running PyIceberg in Windows, `pyiceberg.io.pyarrow.PyArrowFileIO.parse_location()` incorrectly resolve Windows path, e.g. `C:\foobar` as a scheme of `C` and causes `Unrecognized filesystem type in URI` error later.
If using `file://` scheme, the path is also incorrectly resolved to `/C:\foobar`. see <https://stackoverflow.com/a/43925228>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #996:
URL: https://github.com/apache/iceberg-python/pull/996#issuecomment-2441733959
@rfung777 Sorry, I was out for a while. Let's give it a try 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]
Posted by "rfung777 (via GitHub)" <gi...@apache.org>.
rfung777 commented on PR #996:
URL: https://github.com/apache/iceberg-python/pull/996#issuecomment-2294949048
I had an attempt of adding the Windows integration tests. Would you help review again please? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]
Posted by "ghost (via GitHub)" <gi...@apache.org>.
ghost closed pull request #996: Support execution in Windows using Local File System and NFS
URL: https://github.com/apache/iceberg-python/pull/996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]
Posted by "rfung777 (via GitHub)" <gi...@apache.org>.
rfung777 commented on PR #996:
URL: https://github.com/apache/iceberg-python/pull/996#issuecomment-2272267033
Thanks for reviewing. New to the Windows integration test in GitHub Actions. I will do a bit of research to see how it is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #996:
URL: https://github.com/apache/iceberg-python/pull/996#issuecomment-2272127267
Thanks for working on this @rfung777 🙌
Ideally, we would also love to have Windows integration tests on Github Actions. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Support execution in Windows using Local File System and NFS [iceberg-python]
Posted by "rfung777 (via GitHub)" <gi...@apache.org>.
rfung777 commented on PR #996:
URL: https://github.com/apache/iceberg-python/pull/996#issuecomment-2282824642
hi @Fokko , I am not having much luck with setting up the Windows integration tests. It seems to require to install Make and Minio. The changes above seems to be localised in the parser function. Shall we push forward with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org