You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/16 14:48:57 UTC
[GitHub] [incubator-devlake] klesh opened a new pull request, #2228: feat: add `mode` to blueprint entity
klesh opened a new pull request, #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228
# Summary
Implement `mode` support for `blueprint`
1. added `mode` field to `blueprint`
2. `tasks` field is not required if `mode` == `NORMAL` because it would be generated by `settings` in the near future
3. `cronConfig` accept `MANUAL`, and won't be scheduled by the system
4. `NORMAL` is not implemented yet
### Does this close any open issues?
Closes #1987
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1158939604
> @e2corporation Hi, I have talked to others, and here is the result:
>
> 1. `enable` means a blueprint is disabled or not, for `enable=false`, neither automation nor manual triggers are allowed.
> 2. as of `cronConfig` should be preserved in between Manual/Automated toggling, I agree, I will add another field `is_manual`
>
> * when `is_manual=true`, `cronConfig` is not required, however, it will be validated if provided.
> * when `is_manual=false`, `cronConfig` is required, and will be validated.
> Let me know your thought.
I think in keeping with our camelCase conventions for API structs we should use `isManual` or just `manual`. `cronConfig` would always have a last known value or default to `hourly` for instance or whatever custom cron syntax the user defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1157769076
@e2corporation Please take a look the api input/output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1158675935
PR updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1157784794
@klesh the `enabled` property on the blueprint was to be used for enabling/disabling the cron scheduling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1159326005
@klesh the `isManual` changes are a nice addition, we'll have to continue the discussion later for `Blueprint.Mode` and how BE interprets 'NORMAL'. Frontend will always send a unified structure so BE can choose what subways to reference whether normal/advanced mode is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1158599558
@e2corporation Hi, I have talked to others, and here is the result:
1. `enable` means a blueprint is disabled or not, for `enable=false`, neither automation nor manual triggers are allowed.
2. as of `cronConfig` should be preserved in between Manual/Automated toggling, I agree, I will add another field `is_manual`
- when `is_manual=true`, `cronConfig` is not required, however, it will be validated if provided.
- when `is_manual=false`, `cronConfig` is required, and will be validated.
Let me know your thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2228: feat: add `mode` to blueprint entity
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2228:
URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1158954731
> > @e2corporation Hi, I have talked to others, and here is the result:
> >
> > 1. `enable` means a blueprint is disabled or not, for `enable=false`, neither automation nor manual triggers are allowed.
> > 2. as of `cronConfig` should be preserved in between Manual/Automated toggling, I agree, I will add another field `is_manual`
> >
> > * when `is_manual=true`, `cronConfig` is not required, however, it will be validated if provided.
> > * when `is_manual=false`, `cronConfig` is required, and will be validated.
> > Let me know your thought.
>
> I think in keeping with our camelCase conventions for API structs we should use `isManual` or just `manual`. `cronConfig` would always have a last known value or default to `hourly` for instance or whatever custom cron syntax the user defined.
They are, check the screen-shots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org