You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/14 06:54:25 UTC

[GitHub] [apisix] spacewander commented on pull request #6300: fix: when proxy-rewrite plugin's conf.headers are missing,conf.method can make effect

spacewander commented on pull request #6300:
URL: https://github.com/apache/apisix/pull/6300#issuecomment-1038715769


   > > The fix LGTM.
   > > You can learn how to write tests via [https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md](https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md?rgh-link-date=2022-02-14T01%3A06%3A06Z) and the current test
   > > https://github.com/apache/apisix/blob/ebe91aa64c4fd26a03ea1ebddc089c577f4e730b/t/plugin/proxy-rewrite3.t#L87-L129
   > 
   > in proxy-rewrite3.t ,I thought the `TEST 2` case according to the original code, it should not succeed。
   
   Let's add a test to prove your suspect. The test is passed in the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org