You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Apache Pulsar Slack <ap...@gmail.com> on 2020/08/26 09:11:03 UTC
Slack digest for #dev - 2020-08-26
2020-08-26 07:00:21 UTC - Jerry Peng: btw pulsar-sql is broken is blocking CI. I think the reason is we haven't really been running the integration tests for it using the image built from the current version. Also upgrading to the new presto version completely broke things:
<https://github.com/apache/pulsar/pull/7194>
----
2020-08-26 07:00:33 UTC - Jerry Peng: cc @Sijie Guo @Matteo Merli
----
2020-08-26 07:10:31 UTC - Sijie Guo: <https://github.com/apache/pulsar/pull/7898>
----
2020-08-26 07:10:54 UTC - Sijie Guo: @ran is fixing the issue
----
2020-08-26 07:11:26 UTC - Sijie Guo: I think Ali refactored some of the CI builds which cause the CI using an old image
----
2020-08-26 07:21:47 UTC - Jerry Peng: cc @Ali Ahmed
----
2020-08-26 07:21:53 UTC - Jerry Peng: thanks @Sijie Guo
----
2020-08-26 07:27:14 UTC - Ali Ahmed: I didn’t change anything meaningful in the sql integration job this is the commit that changed the image build command
9f687d3f67d7534cb9ee77ddd2c7d0f24d34d0b4
----
2020-08-26 07:28:53 UTC - Ali Ahmed: I am not sure why these ci changed were approved
<https://github.com/apache/pulsar/pull/7701/files>
----
2020-08-26 07:29:54 UTC - Sijie Guo: @Ali Ahmed it doesn’t change the CI
----
2020-08-26 07:30:22 UTC - Sijie Guo: Ran tried to add the logic in his CI to build a new image
----
2020-08-26 07:31:08 UTC - Sijie Guo: If you check the code, the PR added code in the CI that were commented out. The PR didn’t change the build behavior.
----
2020-08-26 07:31:23 UTC - Sijie Guo: The build behavior has been changed before it.
----
2020-08-26 07:33:13 UTC - Ali Ahmed: I only see build steps being commented out in the pr
<https://github.com/apache/pulsar/pull/7701/files#diff-a618acbf44f9234d2ba74c8f64ce98f9>
----
2020-08-26 07:33:27 UTC - Ali Ahmed: I don’t see any additions
----
2020-08-26 07:33:43 UTC - Sijie Guo: It is not commented
----
2020-08-26 07:33:57 UTC - Sijie Guo: `+` means these are newly added lines
----
2020-08-26 07:34:14 UTC - Sijie Guo: It doesn’t comment any steps.
----
2020-08-26 07:34:23 UTC - Sijie Guo: It add lines that are commented out
----
2020-08-26 07:42:46 UTC - Sijie Guo: looking into the history. I think the change was introduced back in Feb
----
2020-08-26 07:43:02 UTC - Sijie Guo: ```- name: build artifacts and docker pulsar latest test image
if: steps.docs.outputs.changed_only == 'no'
run: mvn -B -f tests/docker-images/pom.xml install -am -Pdocker -DskipTests```
----
2020-08-26 07:43:23 UTC - Sijie Guo: The original command is
```- name: build artifacts and docker image
if: steps.docs.outputs.changed_only == 'no'
run: mvn -B install -Dorg.slf4j.simpleLogger.defaultLogLevel=ERROR -Pdocker -DskipTests```
----
2020-08-26 07:43:34 UTC - Sijie Guo: @ran is going to fix it.
----
2020-08-26 07:43:38 UTC - Ali Ahmed: ok
----
2020-08-26 07:44:27 UTC - ran: ok
----