You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mvfc (via GitHub)" <gi...@apache.org> on 2025/05/13 11:46:25 UTC
[PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
mvfc opened a new pull request, #50534:
URL: https://github.com/apache/airflow/pull/50534
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
Sendgrid fucked up again, put a new dependency on the package but didn't add it to the getDependencies on their setup.py
They already made a PR to fix it, this one should fix the CI on our end
Also their new release is supposed to include werkzeug in setup.py so no need for us to fix it anymore
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "mvfc (via GitHub)" <gi...@apache.org>.
mvfc commented on code in PR #50534:
URL: https://github.com/apache/airflow/pull/50534#discussion_r2087271949
##########
providers/sendgrid/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"sendgrid>=6.0.0",
- "werkzeug>=2.2,<4", # Temporary till we can merge https://github.com/apache/airflow/pull/50221
+ "ecdsa>=0.19.1,<1", # remove when https://github.com/sendgrid/sendgrid-python/pull/1102 is solved
Review Comment:
https://github.com/apache/airflow/pull/50553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #50534:
URL: https://github.com/apache/airflow/pull/50534#discussion_r2086897256
##########
providers/sendgrid/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"sendgrid>=6.0.0",
- "werkzeug>=2.2,<4", # Temporary till we can merge https://github.com/apache/airflow/pull/50221
+ "ecdsa>=0.19.1,<1", # remove when https://github.com/sendgrid/sendgrid-python/pull/1102 is solved
Review Comment:
The comment should still be waiting for https://github.com/apache/airflow/pull/50221 as well
We can't really remove the dependency till we update sendgrid SDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #50534:
URL: https://github.com/apache/airflow/pull/50534#discussion_r2086897256
##########
providers/sendgrid/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"sendgrid>=6.0.0",
- "werkzeug>=2.2,<4", # Temporary till we can merge https://github.com/apache/airflow/pull/50221
+ "ecdsa>=0.19.1,<1", # remove when https://github.com/sendgrid/sendgrid-python/pull/1102 is solved
Review Comment:
The comment should still be waiting for https://github.com/apache/airflow/pull/50221 as well
We can't really remove the dependency till we update sendgrid SDK isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "mvfc (via GitHub)" <gi...@apache.org>.
mvfc commented on code in PR #50534:
URL: https://github.com/apache/airflow/pull/50534#discussion_r2086909183
##########
providers/sendgrid/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"sendgrid>=6.0.0",
- "werkzeug>=2.2,<4", # Temporary till we can merge https://github.com/apache/airflow/pull/50221
+ "ecdsa>=0.19.1,<1", # remove when https://github.com/sendgrid/sendgrid-python/pull/1102 is solved
Review Comment:
we're already using sendgrid>=6.0.0 on the provider, so its taking latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "mvfc (via GitHub)" <gi...@apache.org>.
mvfc commented on code in PR #50534:
URL: https://github.com/apache/airflow/pull/50534#discussion_r2086911926
##########
providers/sendgrid/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"sendgrid>=6.0.0",
- "werkzeug>=2.2,<4", # Temporary till we can merge https://github.com/apache/airflow/pull/50221
+ "ecdsa>=0.19.1,<1", # remove when https://github.com/sendgrid/sendgrid-python/pull/1102 is solved
Review Comment:
good point, thought since we take >=6.0.0 it would take already the latest one, bad of my part to assume
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "mvfc (via GitHub)" <gi...@apache.org>.
mvfc commented on code in PR #50534:
URL: https://github.com/apache/airflow/pull/50534#discussion_r2086909183
##########
providers/sendgrid/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"sendgrid>=6.0.0",
- "werkzeug>=2.2,<4", # Temporary till we can merge https://github.com/apache/airflow/pull/50221
+ "ecdsa>=0.19.1,<1", # remove when https://github.com/sendgrid/sendgrid-python/pull/1102 is solved
Review Comment:
we're already using sendgrid>=6.0.0 on the provider, so its taking latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #50534:
URL: https://github.com/apache/airflow/pull/50534#issuecomment-2876253552
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix ci: remove werkzeug and add ecdsa for dependencies of sendgrid [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #50534:
URL: https://github.com/apache/airflow/pull/50534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org