You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/10/01 00:08:00 UTC
[jira] [Commented] (PHOENIX-6159) Phoenix-pherf writes the result
file even disableRuntimeResult flag is true
[ https://issues.apache.org/jira/browse/PHOENIX-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205156#comment-17205156 ]
Hadoop QA commented on PHOENIX-6159:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m 44s{color} | {color:blue} phoenix-pherf in master has 42 extant spotbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} phoenix-pherf: The patch generated 7 new + 101 unchanged - 3 fixed = 108 total (was 104) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 19s{color} | {color:green} phoenix-pherf in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 7s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 31m 21s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59/artifact/patchprocess/Dockerfile |
| JIRA Issue | PHOENIX-6159 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13012367/PHOENIX-6159.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux dc8ca0fd690f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / bb7f000 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59/artifact/patchprocess/diff-checkstyle-phoenix-pherf.txt |
| whitespace | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59/artifact/patchprocess/whitespace-tabs.txt |
| Test Results | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59/testReport/ |
| Max. process+thread count | 1540 (vs. ulimit of 30000) |
| modules | C: phoenix-pherf U: phoenix-pherf |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Phoenix-pherf writes the result file even disableRuntimeResult flag is true
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-6159
> URL: https://issues.apache.org/jira/browse/PHOENIX-6159
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6159.patch
>
>
> The ([MultiThreadedRunner|#L109])] writes the result to the file without check the writeRuntimeResults value.
> I'm not sure if anyone is using this [disableRuntimeResult param in Pherf.java|https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L156], which is not presenting what it indicates. I prefer to fix the behavior and match the meaning of disableRuntimeResult.
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)