You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/03/21 17:55:46 UTC
[GitHub] couchdb pull request: Fix/build2
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb/pull/190
Fix/build2
Fixing the build / tests and removing a global var
Feel free to squash, separated them for better reviewing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb fix/build2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit e7763dfb2d2ad8119ee883002e60ec7edde791c7
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-03-21T16:25:17Z
Fauxton: fix intendation
commit ca5913eda5cb2d70d38ed7ed286bfd835a2b303d
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-03-21T16:25:52Z
Fauxton: fix global var
commit 5bdfa6c41c1dfd9782907b513954cdbd0b6edaa2
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-03-21T16:49:15Z
Fauxton: Fix tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix/build2
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/190#issuecomment-38301742
+1 Thank you for writing tests Robert!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix/build2
Posted by andywenk <gi...@git.apache.org>.
Github user andywenk commented on the pull request:
https://github.com/apache/couchdb/pull/190#issuecomment-38321678
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix/build2
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---