You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/13 08:20:00 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1764: chore: added Feilds to Upstream module
juzhiyuan opened a new pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Hi, this PR aims to add the missing fields to Upstream Form, according to schema_def. (https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L114)
- [x] Concurrency
- [ ] ...
**Related issues**
fix/resolve #0001
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit ece1c976a1aef4916dfaffd97c5097ac8db3509e
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 202b52358b9e8c4b889df25180878afd20341e90
https://app.netlify.com/sites/apisix-dashboard/deploys/6076f91804e54a0008a93ade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit e16ac2ae97addab37efae1233b012b719edc3a5c
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 9cb53d288ca8fea8065935615583c7a76243419e
https://app.netlify.com/sites/apisix-dashboard/deploys/6076c9f1e8fdc5000770c847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 60219710b36a751eefbf178b808e35a77ddb648b
https://app.netlify.com/sites/apisix-dashboard/deploys/607697fcffd12100083ac67e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 900e6a3c8ead5757d4214e69a9720b5e0b2305d8
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit d38c7ca0c124f22f83e983ab88d716e134136808
https://app.netlify.com/sites/apisix-dashboard/deploys/6076fe4bef5d9900071cf75d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r612914396
##########
File path: web/src/components/Upstream/components/active-check/Host.tsx
##########
@@ -26,30 +26,30 @@ const Component: React.FC<Props> = ({ readonly }) => {
const { formatMessage } = useIntl()
return (
<Form.Item
- label={formatMessage({ id: 'page.upstream.step.healthyCheck.activeHost' })}
+ label={formatMessage({ id: 'component.upstream.fields.checks.active.host' })}
required
- tooltip={formatMessage({ id: 'page.upstream.checks.active.host.description' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.checks.active.host.tooltip' })}
+ style={{ marginBottom: 0 }}
>
<Form.Item
- style={{ marginBottom: 0 }}
name={['checks', 'active', 'host']}
rules={[
{
required: true,
- message: formatMessage({ id: 'page.upstream.step.input.healthyCheck.activeHost' }),
+ message: formatMessage({ id: 'component.upstream.fields.checks.active.host.required' }),
},
{
pattern: new RegExp(
- /(^([1-9]?\d|1\d{2}|2[0-4]\d|25[0-5])(\.(25[0-5]|1\d{2}|2[0-4]\d|[1-9]?\d)){3}$|^(?![0-9.]+$)([a-zA-Z0-9_-]+)(\.[a-zA-Z0-9_-]+){0,}$)/,
Review comment:
host_def_pat
##########
File path: web/src/components/Upstream/components/active-check/Host.tsx
##########
@@ -26,30 +26,30 @@ const Component: React.FC<Props> = ({ readonly }) => {
const { formatMessage } = useIntl()
return (
<Form.Item
- label={formatMessage({ id: 'page.upstream.step.healthyCheck.activeHost' })}
+ label={formatMessage({ id: 'component.upstream.fields.checks.active.host' })}
required
- tooltip={formatMessage({ id: 'page.upstream.checks.active.host.description' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.checks.active.host.tooltip' })}
+ style={{ marginBottom: 0 }}
>
<Form.Item
- style={{ marginBottom: 0 }}
name={['checks', 'active', 'host']}
rules={[
{
required: true,
- message: formatMessage({ id: 'page.upstream.step.input.healthyCheck.activeHost' }),
+ message: formatMessage({ id: 'component.upstream.fields.checks.active.host.required' }),
},
{
pattern: new RegExp(
- /(^([1-9]?\d|1\d{2}|2[0-4]\d|25[0-5])(\.(25[0-5]|1\d{2}|2[0-4]\d|[1-9]?\d)){3}$|^(?![0-9.]+$)([a-zA-Z0-9_-]+)(\.[a-zA-Z0-9_-]+){0,}$)/,
Review comment:
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613049577
##########
File path: web/cypress/fixtures/selector.json
##########
@@ -85,7 +74,6 @@
"pageTwoActived": ".ant-pagination-item-2.ant-pagination-item-active",
"selectDropdown": ".ant-select-dropdown",
"codeMirrorMode": "[data-cy='code-mirror-mode']",
- "selectJSON":".ant-select-dropdown [label=JSON]",
-
+ "selectJSON": ".ant-select-dropdown [label=JSON]",
"deleteAlert": ".ant-modal-body"
-}
+}
Review comment:
new line please.
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -86,14 +87,18 @@ const UpstreamForm: React.FC<Props> = forwardRef(
if (required) {
requestAnimationFrame(() => {
form.resetFields();
- form.setFieldsValue(DEFAULT_UPSTREAM);
setHiddenForm(false);
});
}
} else {
if (upstream_id) {
requestAnimationFrame(() => {
- form.setFieldsValue(list.find((item) => item.id === upstream_id));
+ const targetData = list.find((item) => item.id === upstream_id) as UpstreamComponent.ResponseData
+ if (targetData) {
+ form.setFieldsValue(transformUpstreamDataFromRequest(targetData));
+ } else {
+ // TODO: 提示 upstream_id 找不到想要的数据
Review comment:
remove Chinese comment.
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.tls.tooltip' })}
+ style={{ marginBottom: 0 }}
+ >
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={["custom", "tls"]}
+ initialValue="disable"
+ >
+ <Select disabled={readonly}>
+ {
+ ["disable", "enable"].map(item => (
+ <Select.Option value={item} key={item}>
+ {formatMessage({ id: `component.global.${item}` })}
+ </Select.Option>
+ ))
+ }
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
+ </Form.Item>
+ <Form.Item
+ noStyle
+ shouldUpdate={(prev, next) => {
+ return prev.custom.tls !== next.custom.tls
+ }}
+ >
+ {
+ () => {
+ if (form.getFieldValue(["custom", "tls"]) === 'enable') {
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_cert' })}
+ name={["tls", "client_cert"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端证书" />
+ </Form.Item>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_key' })}
+ name={["tls", "client_key"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端私钥" />
Review comment:
ditto
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.tls.tooltip' })}
+ style={{ marginBottom: 0 }}
+ >
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={["custom", "tls"]}
+ initialValue="disable"
+ >
+ <Select disabled={readonly}>
+ {
+ ["disable", "enable"].map(item => (
+ <Select.Option value={item} key={item}>
+ {formatMessage({ id: `component.global.${item}` })}
+ </Select.Option>
+ ))
+ }
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
+ </Form.Item>
+ <Form.Item
+ noStyle
+ shouldUpdate={(prev, next) => {
+ return prev.custom.tls !== next.custom.tls
+ }}
+ >
+ {
+ () => {
+ if (form.getFieldValue(["custom", "tls"]) === 'enable') {
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_cert' })}
+ name={["tls", "client_cert"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端证书" />
Review comment:
ditto
##########
File path: web/src/components/Upstream/components/passive-check/Type.tsx
##########
@@ -15,43 +15,55 @@
* limitations under the License.
*/
import React from 'react'
-import { Form, Select } from 'antd'
+import { Form, Select, Row, Col } from 'antd'
+import { useIntl } from 'umi'
type Props = {
readonly?: boolean
}
-const PassiveCheckTypeComponent: React.FC<Props> = ({ readonly }) => {
- const options = [
- {
- label: "HTTP",
- value: "http"
- }, {
- label: "HTTPs",
- value: "https"
- }, {
- label: "TCP",
- value: "tcp"
- }
- ]
+const options = [
+ {
+ label: "HTTP",
+ value: "http"
+ }, {
+ label: "HTTPs",
+ value: "https"
+ }, {
+ label: "TCP",
+ value: "tcp"
+ }
+]
+
+const ActiveCheckTypeComponent: React.FC<Props> = ({ readonly }) => {
+ const { formatMessage } = useIntl()
return (
<Form.Item
- label="Type"
- name={['checks', 'passive', 'type']}
- rules={[{ required: true }]}
+ label={formatMessage({ id: 'component.upstream.fields.checks.active.type' })}
+ style={{ marginBottom: 0 }}
+ tooltip={formatMessage({ id: 'component.upstream.fields.checks.active.type.tooltip' })}
>
- <Select disabled={readonly}>
- {options.map(item => {
- return (
- <Select.Option value={item.value} key={item.value}>
- {item.label}
- </Select.Option>
- );
- })}
- </Select>
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={['checks', 'passive', 'type']}
+ initialValue="http"
+ >
+ <Select disabled={readonly}>
+ {options.map(item => {
+ return (
+ <Select.Option value={item.value} key={item.value}>
+ {item.label}
+ </Select.Option>
+ );
+ })}
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
</Form.Item>
)
}
-export default PassiveCheckTypeComponent
+export default ActiveCheckTypeComponent
Review comment:
wrong name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 8f8d1097b972d1688e17b2e69b4eef71a8d5d527
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 47db0f7fc80e900fa378bcb20b851c88eeeeba73
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 881f3655cafe9d1d9d7b352804dc92a91612092d
https://app.netlify.com/sites/apisix-dashboard/deploys/60757de50d55c100075c88d3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613732523
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -86,14 +87,18 @@ const UpstreamForm: React.FC<Props> = forwardRef(
if (required) {
requestAnimationFrame(() => {
form.resetFields();
- form.setFieldsValue(DEFAULT_UPSTREAM);
setHiddenForm(false);
});
}
} else {
if (upstream_id) {
requestAnimationFrame(() => {
- form.setFieldsValue(list.find((item) => item.id === upstream_id));
+ const targetData = list.find((item) => item.id === upstream_id) as UpstreamComponent.ResponseData
+ if (targetData) {
+ form.setFieldsValue(transformUpstreamDataFromRequest(targetData));
+ } else {
+ // TODO: 提示 upstream_id 找不到想要的数据
Review comment:
sure! I missed some notes, and will file a new PR to remove all Chinese.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 38c64210defabc7e6ade86398bdf19a117bca291
https://app.netlify.com/sites/apisix-dashboard/deploys/607680524ba00c00092fde6b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-820033863
Hi @imjoey @LiteSun , thanks for your reviewing, just noticed there have some comments related to i18n (I missed them), if no urgent bug needs to be fixed, I would prefer resolving them in the new PR, because GitHub Action will queue unexpected those days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 0c0c663ef326e1f737a7c5f82315906fc1381a2e
https://app.netlify.com/sites/apisix-dashboard/deploys/60758693d3e1ed0007ce4e77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit bbe67a5fe7db2d05a9fca0d52a21b3d85a063700
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 41d9e281632102b249f690788493ff55bd0ef4d1
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613731830
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.tls.tooltip' })}
+ style={{ marginBottom: 0 }}
+ >
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={["custom", "tls"]}
+ initialValue="disable"
+ >
+ <Select disabled={readonly}>
+ {
+ ["disable", "enable"].map(item => (
+ <Select.Option value={item} key={item}>
+ {formatMessage({ id: `component.global.${item}` })}
+ </Select.Option>
+ ))
+ }
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
+ </Form.Item>
+ <Form.Item
+ noStyle
+ shouldUpdate={(prev, next) => {
+ return prev.custom.tls !== next.custom.tls
+ }}
+ >
+ {
+ () => {
+ if (form.getFieldValue(["custom", "tls"]) === 'enable') {
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_cert' })}
+ name={["tls", "client_cert"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端证书" />
Review comment:
@juzhiyuan The text of `placeholder` seems no i18n here. As expected?
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.tls.tooltip' })}
+ style={{ marginBottom: 0 }}
+ >
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={["custom", "tls"]}
+ initialValue="disable"
+ >
+ <Select disabled={readonly}>
+ {
+ ["disable", "enable"].map(item => (
+ <Select.Option value={item} key={item}>
+ {formatMessage({ id: `component.global.${item}` })}
+ </Select.Option>
+ ))
+ }
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
+ </Form.Item>
+ <Form.Item
+ noStyle
+ shouldUpdate={(prev, next) => {
+ return prev.custom.tls !== next.custom.tls
+ }}
+ >
+ {
+ () => {
+ if (form.getFieldValue(["custom", "tls"]) === 'enable') {
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_cert' })}
+ name={["tls", "client_cert"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端证书" />
+ </Form.Item>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_key' })}
+ name={["tls", "client_key"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端私钥" />
Review comment:
ditto here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-819553138
CI passes on local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 202b52358b9e8c4b889df25180878afd20341e90
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613734113
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.tls.tooltip' })}
+ style={{ marginBottom: 0 }}
+ >
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={["custom", "tls"]}
+ initialValue="disable"
+ >
+ <Select disabled={readonly}>
+ {
+ ["disable", "enable"].map(item => (
+ <Select.Option value={item} key={item}>
+ {formatMessage({ id: `component.global.${item}` })}
+ </Select.Option>
+ ))
+ }
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
+ </Form.Item>
+ <Form.Item
+ noStyle
+ shouldUpdate={(prev, next) => {
+ return prev.custom.tls !== next.custom.tls
+ }}
+ >
+ {
+ () => {
+ if (form.getFieldValue(["custom", "tls"]) === 'enable') {
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_cert' })}
+ name={["tls", "client_cert"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端证书" />
Review comment:
No, same as your last comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit c7ea9a1815d7b2ffdefeac363006897718247746
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit ece1c976a1aef4916dfaffd97c5097ac8db3509e
https://app.netlify.com/sites/apisix-dashboard/deploys/6075954ba0524f0007e11ff5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit e4d62bbe6898cb747ac0ad23d92a6eae6f75d582
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r612915488
##########
File path: web/src/components/Upstream/components/active-check/Healthy/HttpStatuses.tsx
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Button, InputNumber } from 'antd'
+import { useIntl } from 'umi'
+import { MinusCircleOutlined, PlusOutlined } from '@ant-design/icons'
+
+import { removeBtnStyle } from '@/components/Upstream'
+
+type Props = {
+ readonly?: boolean
+}
+
+const Component: React.FC<Props> = ({ readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <Form.List name={['checks', 'active', 'healthy', 'http_statuses']} initialValue={[200, 302]}>
+ {(fields, { add, remove }) => (
+ <>
+ <Form.Item
+ required
Review comment:
all those options are optional, only for style effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 1890dc751a8d7284e34c8f89d8449425e75d8c23
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 087848634ad292b2a7b87f96fa2b2b8511cb547b
https://app.netlify.com/sites/apisix-dashboard/deploys/607653593ceae10008b23aa2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r615319850
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -86,14 +87,18 @@ const UpstreamForm: React.FC<Props> = forwardRef(
if (required) {
requestAnimationFrame(() => {
form.resetFields();
- form.setFieldsValue(DEFAULT_UPSTREAM);
setHiddenForm(false);
});
}
} else {
if (upstream_id) {
requestAnimationFrame(() => {
- form.setFieldsValue(list.find((item) => item.id === upstream_id));
+ const targetData = list.find((item) => item.id === upstream_id) as UpstreamComponent.ResponseData
+ if (targetData) {
+ form.setFieldsValue(transformUpstreamDataFromRequest(targetData));
+ } else {
+ // TODO: 提示 upstream_id 找不到想要的数据
Review comment:
I just filed a PR to make the Upstream Logics more clear https://github.com/apache/apisix-dashboard/pull/1784, no need to check if target data lost any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit be690b972dbb4b1d78e277e35dc1858cf88aedf7
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818660861
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1764](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (900e6a3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/537b4ffdd5898879cbc611809e503f5e2b943254?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (537b4ff) will **decrease** coverage by `9.23%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 900e6a3 differs from pull request most recent head 881f365. Consider uploading reports for the commit 881f365 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
- Coverage 71.55% 62.32% -9.24%
==========================================
Files 47 47
Lines 3129 3129
==========================================
- Hits 2239 1950 -289
- Misses 646 866 +220
- Partials 244 313 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `62.32% <ø> (ø)` | |
| backend-e2e-test-ginkgo | `49.18% <ø> (-0.16%)` | :arrow_down: |
| backend-unit-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.68% <0.00%> (-29.35%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `77.14% <0.00%> (-13.58%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [537b4ff...881f365](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 7a0ccd906c2aca25740c38f2d2f64d953b20930e
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 0efb744931c5e776d80cd1ae5ca25fc38e5d90ff
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 155fb081408c0964acbfd9873d4844cf6b054142
https://app.netlify.com/sites/apisix-dashboard/deploys/60769161c864a0000754634c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 7a0ccd906c2aca25740c38f2d2f64d953b20930e
https://app.netlify.com/sites/apisix-dashboard/deploys/6075834344a1670008a86778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit c7ea9a1815d7b2ffdefeac363006897718247746
https://app.netlify.com/sites/apisix-dashboard/deploys/60776a2e462bf000080d2e3f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818660861
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1764](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (900e6a3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/537b4ffdd5898879cbc611809e503f5e2b943254?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (537b4ff) will **decrease** coverage by `24.51%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 900e6a3 differs from pull request most recent head 881f365. Consider uploading reports for the commit 881f365 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1764 +/- ##
===========================================
- Coverage 71.55% 47.04% -24.52%
===========================================
Files 47 47
Lines 3129 3129
===========================================
- Hits 2239 1472 -767
- Misses 646 1395 +749
- Partials 244 262 +18
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `47.04% <ø> (-15.28%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.35% <0.00%> (-71.43%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `31.42% <0.00%> (-59.29%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `41.73% <0.00%> (-50.44%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1764/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [537b4ff...881f365](https://codecov.io/gh/apache/apisix-dashboard/pull/1764?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 0efb744931c5e776d80cd1ae5ca25fc38e5d90ff
https://app.netlify.com/sites/apisix-dashboard/deploys/607646e75773f10007f376f5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 881f3655cafe9d1d9d7b352804dc92a91612092d
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 8ebe5b91d376dc1662ca0ea1593a4811428e1857
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 900e6a3c8ead5757d4214e69a9720b5e0b2305d8
https://app.netlify.com/sites/apisix-dashboard/deploys/60755426a8b6c300081d7fec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 1890dc751a8d7284e34c8f89d8449425e75d8c23
https://app.netlify.com/sites/apisix-dashboard/deploys/60779cc9fddd4500079143f9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 60219710b36a751eefbf178b808e35a77ddb648b
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit c7eb03e4903947d7745205581d0e5e3e4df6f68b
https://app.netlify.com/sites/apisix-dashboard/deploys/6075807113dfe70008ab7b1c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613732581
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -86,14 +87,18 @@ const UpstreamForm: React.FC<Props> = forwardRef(
if (required) {
requestAnimationFrame(() => {
form.resetFields();
- form.setFieldsValue(DEFAULT_UPSTREAM);
setHiddenForm(false);
});
}
} else {
if (upstream_id) {
requestAnimationFrame(() => {
- form.setFieldsValue(list.find((item) => item.id === upstream_id));
+ const targetData = list.find((item) => item.id === upstream_id) as UpstreamComponent.ResponseData
+ if (targetData) {
+ form.setFieldsValue(transformUpstreamDataFromRequest(targetData));
+ } else {
+ // TODO: 提示 upstream_id 找不到想要的数据
Review comment:
yes, English only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 098bb212df3b5956a15ef465fc7d060f96829a49
https://app.netlify.com/sites/apisix-dashboard/deploys/607660dc3822f800073e0701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit bbe67a5fe7db2d05a9fca0d52a21b3d85a063700
https://app.netlify.com/sites/apisix-dashboard/deploys/6077572e0d2afb000756b170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r612904586
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const CUSTOM_FIELD_KEY = "custom__enable_tls"
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label="启用 TLS"
Review comment:
i18n.
##########
File path: web/src/components/Upstream/components/active-check/Healthy/HttpStatuses.tsx
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Button, InputNumber } from 'antd'
+import { useIntl } from 'umi'
+import { MinusCircleOutlined, PlusOutlined } from '@ant-design/icons'
+
+import { removeBtnStyle } from '@/components/Upstream'
+
+type Props = {
+ readonly?: boolean
+}
+
+const Component: React.FC<Props> = ({ readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <Form.List name={['checks', 'active', 'healthy', 'http_statuses']} initialValue={[200, 302]}>
+ {(fields, { add, remove }) => (
+ <>
+ <Form.Item
+ required
Review comment:
Does the form validation work when written this way?
##########
File path: web/src/components/Upstream/components/active-check/Host.tsx
##########
@@ -26,30 +26,30 @@ const Component: React.FC<Props> = ({ readonly }) => {
const { formatMessage } = useIntl()
return (
<Form.Item
- label={formatMessage({ id: 'page.upstream.step.healthyCheck.activeHost' })}
+ label={formatMessage({ id: 'component.upstream.fields.checks.active.host' })}
required
- tooltip={formatMessage({ id: 'page.upstream.checks.active.host.description' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.checks.active.host.tooltip' })}
+ style={{ marginBottom: 0 }}
>
<Form.Item
- style={{ marginBottom: 0 }}
name={['checks', 'active', 'host']}
rules={[
{
required: true,
- message: formatMessage({ id: 'page.upstream.step.input.healthyCheck.activeHost' }),
+ message: formatMessage({ id: 'component.upstream.fields.checks.active.host.required' }),
},
{
pattern: new RegExp(
- /(^([1-9]?\d|1\d{2}|2[0-4]\d|25[0-5])(\.(25[0-5]|1\d{2}|2[0-4]\d|[1-9]?\d)){3}$|^(?![0-9.]+$)([a-zA-Z0-9_-]+)(\.[a-zA-Z0-9_-]+){0,}$)/,
Review comment:
Any reference about this `RegExp ` change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit e16ac2ae97addab37efae1233b012b719edc3a5c
https://app.netlify.com/sites/apisix-dashboard/deploys/607642cce8fdc5000760670a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 154eff4cd7ff832370a97189b2a25283779343c8
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-820033863
Hi @imjoey @LiteSun , thanks for your reviewing, just noticed there have some comments related to i18n (I missed them), I would prefer resolving them in the new PR, because GitHub Action will queue unexpected those days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613729781
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -86,14 +87,18 @@ const UpstreamForm: React.FC<Props> = forwardRef(
if (required) {
requestAnimationFrame(() => {
form.resetFields();
- form.setFieldsValue(DEFAULT_UPSTREAM);
setHiddenForm(false);
});
}
} else {
if (upstream_id) {
requestAnimationFrame(() => {
- form.setFieldsValue(list.find((item) => item.id === upstream_id));
+ const targetData = list.find((item) => item.id === upstream_id) as UpstreamComponent.ResponseData
+ if (targetData) {
+ form.setFieldsValue(transformUpstreamDataFromRequest(targetData));
+ } else {
+ // TODO: 提示 upstream_id 找不到想要的数据
Review comment:
@juzhiyuan should we use English here? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit be690b972dbb4b1d78e277e35dc1858cf88aedf7
https://app.netlify.com/sites/apisix-dashboard/deploys/6075a0a404720a0007544d9d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: feat: added default values & missing fields to Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r613734245
##########
File path: web/src/components/Upstream/components/TLS.tsx
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const TLSComponent: React.FC<Props> = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls' })}
+ tooltip={formatMessage({ id: 'component.upstream.fields.tls.tooltip' })}
+ style={{ marginBottom: 0 }}
+ >
+ <Row>
+ <Col span={5}>
+ <Form.Item
+ name={["custom", "tls"]}
+ initialValue="disable"
+ >
+ <Select disabled={readonly}>
+ {
+ ["disable", "enable"].map(item => (
+ <Select.Option value={item} key={item}>
+ {formatMessage({ id: `component.global.${item}` })}
+ </Select.Option>
+ ))
+ }
+ </Select>
+ </Form.Item>
+ </Col>
+ </Row>
+ </Form.Item>
+ <Form.Item
+ noStyle
+ shouldUpdate={(prev, next) => {
+ return prev.custom.tls !== next.custom.tls
+ }}
+ >
+ {
+ () => {
+ if (form.getFieldValue(["custom", "tls"]) === 'enable') {
+ return (
+ <React.Fragment>
+ <Form.Item
+ label={formatMessage({ id: 'component.upstream.fields.tls.client_cert' })}
+ name={["tls", "client_cert"]}
+ required
+ rules={[{ required: true, message: "" }, { max: 64 * 1024 }, { min: 128 }]}
+ >
+ <Input.TextArea disabled={readonly} minLength={128} maxLength={64 * 1024} rows={5} placeholder="请输入客户端证书" />
Review comment:
Due to CI will take a long time to run, I would prefer to remove them in the new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 47db0f7fc80e900fa378bcb20b851c88eeeeba73
https://app.netlify.com/sites/apisix-dashboard/deploys/6076a323c7edc60008675aab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 8f8d1097b972d1688e17b2e69b4eef71a8d5d527
https://app.netlify.com/sites/apisix-dashboard/deploys/60758a17a8b6c300082579d4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit d829414f6c21267c63413b53a1f6cc382467bc29
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 9cb53d288ca8fea8065935615583c7a76243419e
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 0c0c663ef326e1f737a7c5f82315906fc1381a2e
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit c7eb03e4903947d7745205581d0e5e3e4df6f68b
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 57739540a246be47314e9ccb55299183873c775e
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit d38c7ca0c124f22f83e983ab88d716e134136808
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit d829414f6c21267c63413b53a1f6cc382467bc29
https://app.netlify.com/sites/apisix-dashboard/deploys/60776e6b1c56fc00074590a3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-820031224
@juzhiyuan please use a better title of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 2810a541544acac02ed0ee56c3231b076f8658c1
https://app.netlify.com/sites/apisix-dashboard/deploys/6077950cc3d26100087349d0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit 2810a541544acac02ed0ee56c3231b076f8658c1
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 8ebe5b91d376dc1662ca0ea1593a4811428e1857
https://app.netlify.com/sites/apisix-dashboard/deploys/60759e33bd48450008cff085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* processing.
Building with commit 154eff4cd7ff832370a97189b2a25283779343c8
https://app.netlify.com/sites/apisix-dashboard/deploys/6076cabb4f2d5700079b484c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343
Deploy preview for *apisix-dashboard* ready!
Built with commit d49319f8c7bf8c1897d7909ceeb6ef5942162cd6
https://deploy-preview-1764--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org