You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/17 14:37:18 UTC

[GitHub] [hudi] Run-Lin opened a new pull request, #5898: [MINOR] Add DiDi to powered_by page

Run-Lin opened a new pull request, #5898:
URL: https://github.com/apache/hudi/pull/5898

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Run-Lin commented on a diff in pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
Run-Lin commented on code in PR #5898:
URL: https://github.com/apache/hudi/pull/5898#discussion_r901215908


##########
website/src/pages/powered-by.md:
##########
@@ -98,5 +98,6 @@ Using Hudi at Yotpo for several usages. Firstly, integrated Hudi as a writer in
 ### Zendesk 
 At [Zendesk](https://www.zendesk.com/), Apache Hudi is adopted for building Data Lake on AWS.
 
-### DiDi 
-At [DiDi](https://www.didiglobal.com/), DiDi is the World‘s Leading Transportation Platform,  Based on the Hadoop ecosystem, we built a new generation of big data platform based on Apache HUDI, which provides record-level updates/deletes  as well as streaming and batch integrated data processing。
\ No newline at end of file
+### DiDi
+[DiDi](https://www.didiglobal.com/) is the World‘s Leading Transportation Platform,  Based on the Hadoop ecosystem, we built a new generation of big data platform based on Apache HUDI, which provides record-level updates/deletes  as well as streaming and batch integrated data processing。

Review Comment:
   I closed the PR 5898  and  created a new PR,Please kindly help to review,   https://github.com/apache/hudi/pull/5906  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159339101

   hi @Run-Lin pull it up in the logo wall
   ![image](https://user-images.githubusercontent.com/10494131/174418455-9772bac8-f255-4a24-897a-1e5bf163dcd9.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Run-Lin commented on a diff in pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
Run-Lin commented on code in PR #5898:
URL: https://github.com/apache/hudi/pull/5898#discussion_r901168951


##########
website/src/pages/powered-by.md:
##########
@@ -98,5 +98,6 @@ Using Hudi at Yotpo for several usages. Firstly, integrated Hudi as a writer in
 ### Zendesk 
 At [Zendesk](https://www.zendesk.com/), Apache Hudi is adopted for building Data Lake on AWS.
 
-### DiDi 
-At [DiDi](https://www.didiglobal.com/), DiDi is the World‘s Leading Transportation Platform,  Based on the Hadoop ecosystem, we built a new generation of big data platform based on Apache HUDI, which provides record-level updates/deletes  as well as streaming and batch integrated data processing。
\ No newline at end of file
+### DiDi
+[DiDi](https://www.didiglobal.com/) is the World‘s Leading Transportation Platform,  Based on the Hadoop ecosystem, we built a new generation of big data platform based on Apache HUDI, which provides record-level updates/deletes  as well as streaming and batch integrated data processing。

Review Comment:
   Okay,  I'll resubmit it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159393080

   @Run-Lin Just resolve the conflict and I can merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159392908

   LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Run-Lin commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
Run-Lin commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159338750

   > @Run-Lin Feel free to add a logo file in this PR . I can pull it up in the logo wall in a following PR.
   
   
   I put logo file in 
   website/static/assets/images/powers/DiDi.png


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Run-Lin closed pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
Run-Lin closed pull request #5898: [MINOR]  Add DiDi to powered_by page
URL: https://github.com/apache/hudi/pull/5898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Run-Lin commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
Run-Lin commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159394693

   > 
   
   There is a 1 failing check, I don't know how to deal with it, could you help me~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars closed pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars closed pull request #5898: [MINOR]  Add DiDi to powered_by page
URL: https://github.com/apache/hudi/pull/5898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159395987

   rebase this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] bhasudha commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159333628

   @Run-Lin  Feel free to add a logo file in this PR . I can pull it up in the logo wall in a following PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #5898:
URL: https://github.com/apache/hudi/pull/5898#discussion_r901037551


##########
website/src/pages/powered-by.md:
##########
@@ -98,5 +98,6 @@ Using Hudi at Yotpo for several usages. Firstly, integrated Hudi as a writer in
 ### Zendesk 
 At [Zendesk](https://www.zendesk.com/), Apache Hudi is adopted for building Data Lake on AWS.
 
-### DiDi 
-At [DiDi](https://www.didiglobal.com/), DiDi is the World‘s Leading Transportation Platform,  Based on the Hadoop ecosystem, we built a new generation of big data platform based on Apache HUDI, which provides record-level updates/deletes  as well as streaming and batch integrated data processing。
\ No newline at end of file
+### DiDi
+[DiDi](https://www.didiglobal.com/) is the World‘s Leading Transportation Platform,  Based on the Hadoop ecosystem, we built a new generation of big data platform based on Apache HUDI, which provides record-level updates/deletes  as well as streaming and batch integrated data processing。

Review Comment:
   this page has been ordering companies by name alphabetically. can you follow the order pls



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on pull request #5898: [MINOR] Add DiDi to powered_by page

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5898:
URL: https://github.com/apache/hudi/pull/5898#issuecomment-1159398268

   > > 
   > 
   > There is a 1 failing check, I don't know how to deal with it, could you help me~
   
   rebase this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org