You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/16 21:50:20 UTC
[GitHub] [commons-numbers] aherbert opened a new pull request #78:
NUMBERS-147: Fix Fraction conversion from double to support 2^31
aherbert opened a new pull request #78: NUMBERS-147: Fix Fraction conversion from double to support 2^31
URL: https://github.com/apache/commons-numbers/pull/78
The value 2^31 can be in the numerator or denominator. Previously the
conversion from double supported up to Integer.MAX_VALUE which is
2^31-1.
Adds common test cases for conversion from double with a max
denominator.
Changed the conversion from a double to use the absolute value and
restore the sign at the end. The conversion is thus identical for
positive or negative values.
A maximum denominator of zero is not allowed and results in an IllegalArgumentException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-numbers] coveralls commented on issue #78: NUMBERS-147:
Fix Fraction conversion from double to support 2^31
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #78: NUMBERS-147: Fix Fraction conversion from double to support 2^31
URL: https://github.com/apache/commons-numbers/pull/78#issuecomment-614941944
[](https://coveralls.io/builds/30133296)
Coverage increased (+0.04%) to 99.63% when pulling **4615cfdabbb840590f9bcbbef1f9281107d23b27 on aherbert:numbers-147-fix** into **5daca57eea93e42323d35659c118aea43815f3cf on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-numbers] coveralls edited a comment on issue #78:
NUMBERS-147: Fix Fraction conversion from double to support 2^31
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #78: NUMBERS-147: Fix Fraction conversion from double to support 2^31
URL: https://github.com/apache/commons-numbers/pull/78#issuecomment-614941944
[](https://coveralls.io/builds/30158774)
Coverage increased (+0.04%) to 99.631% when pulling **996b6627babb875916a6940e14f6fbe7bdf3d3fc on aherbert:numbers-147-fix** into **5daca57eea93e42323d35659c118aea43815f3cf on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services