[jira] [Commented] (NIFI-11213) Changes in older versioned flows are not recognized when they are contained by other flow

["Simon Bence (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-11213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697132#comment-17697132 ] 

Simon Bence commented on NIFI-11213:
------------------------------------

h1. Test Plan

h3. Preparation for the plan

Start R1 NiFi Registry. The attached flow snapshots are depending on a registry running on `http://localhost:18080/` which might need to be modified

h2. Test Case #1:  Covering issued case

h4. Desription
Handling version change of INNER group when version coordinates depends on "registryURL" 

h4. Preparation
Import CFM-3234-TC1-INNER and  Import CFM-3234-TC1-OUTER to R1

h4. Scenario
GIVEN import CFM-3234-TC1-OUTER from R1
AND a component in the encontained CFM-3234-TC1-INNER is modified
WHEN the changes of encontained CFM-3234-TC1-INNER are committed
AND local changes of CFM-3234-TC1-OUTER are listed
THEN CFM-3234-TC1-INNER is listed as "Flow Version Changed"

h4. Note
A similar flow might be created by using a version of NiFi from before 1.18.0. At the time enclosed flows were located based on registryUrl.

h2. Test Case #2:  Regression

h4. Desription
Handling version change of INNER group when version coordinates depends on "storageLocation" 

h4. Preparation
Import CFM-3234-TC2-INNER and  Import CFM-3234-TC2-OUTER to R1

h4. Scenario
GIVEN import CFM-3234-TC2-OUTER from R1
AND a component in the encontained CFM-3234-TC2-INNER is modified
WHEN the changes of encontained CFM-3234-TC2-INNER are committed
AND local changes of CFM-3234-TC2-OUTER are listed
THEN CFM-3234-TC2-INNER is listed as "Flow Version Changed"

h4. Note
The similar behaviour is expected without this change too.


> Changes in older versioned flows are not recognized when they are contained by other flow
> -----------------------------------------------------------------------------------------
>
>                 Key: NIFI-11213
>                 URL: https://issues.apache.org/jira/browse/NIFI-11213
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Simon Bence
>            Assignee: Simon Bence
>            Priority: Major
>         Attachments: CFM-3234-TC1-INNER-version-1.json, CFM-3234-TC1-OUTER-version-1.json, CFM-3234-TC2-INNER-version-1.json, CFM-3234-TC2-OUTER-version-1.json
>
>
> h3. Preparation steps:
> Given process group "Inner" is created and added to version control
> Given process group "Outer" is created and added to version control containing Inner PG as well
> h3. Actual scenario:
> Add "Outer" to the canvas from Registry
> Change something within Inner PG (rename a processor or such)
> Commit the change
> Expected behaviour:
> As "Inner" has the new version now, I would expect NiFi to show local changes in the Outer PG, namely the version change for Inner.
> h3. Actual behaviour:
> The actual behaviour depends on what version of NiFi was used for preparation. If the version contains the Registry refactoring (so 1.18.0+) and the snapshot is saved using storageLocation, the actual behaviour matches with the expected. For older NiFis (using URI to locate contained versioned flows) Outer will not show any changes, both PGs will be "green"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)