[GitHub] [pulsar] lhotari commented on pull request #14261: Clean up individually deleted messages before the mark-delete position

[GitBox <gi...@apache.org>]

lhotari commented on pull request #14261:
URL: https://github.com/apache/pulsar/pull/14261#issuecomment-1038689581


   This fix reminds me of the issue I was seeing in #10054 with replicated subscriptions. In that case, it seems that because of the "marker messages" [being acknowledged automatically](https://github.com/apache/pulsar/blob/d3465529d33f0bf35fe837444e2216085eecbc5f/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java#L97), the messages get deleted out of order in all cases where the consumer doesn't keep up with the producer. This explains the [`individuallyDeletedMessages` ranges seen when the problem occurs in #10054](https://github.com/apache/pulsar/issues/10054#issuecomment-810919739). When there are `individuallyDeletedMessages` in the subscription, the `markDeletedPosition` doesn't get updated and therefore the subscription state doesn't get replicated.
   @merlimat could this PR help resolve the above scenario?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org