You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/17 22:01:56 UTC
[GitHub] [arrow-julia] jonalm opened a new pull request #309: WIP change scoped enums behavior
jonalm opened a new pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309
Implement suggestions for https://github.com/apache/arrow-julia/issues/308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] jonalm commented on pull request #309: WIP change scoped enums behavior
Posted by GitBox <gi...@apache.org>.
jonalm commented on pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309#issuecomment-1076872383
@quinnj Took me some time to update all usages of the enums in the package, but I got all tests to pass now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] jonalm commented on pull request #309: WIP change scoped enums behavior
Posted by GitBox <gi...@apache.org>.
jonalm commented on pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309#issuecomment-1072871189
I will to find time for that within a couple of days. But before I do so, should we reconsider the name of the primitive type, i.e. something other than with leading underscore? I just saw the announcement of enumx.jl https://discourse.julialang.org/t/ann-enumx-jl-improved-enums-for-julia/78096 , which has implemented a similar idea, but using `T` as the name of the type inside the module. E.g. for `@scopedenum MyEnum::Base.UInt16 A=0 B=1` the values would be accessed as `MyEnum.A` and the primitive type could be accessed as `MyEnum.T`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] jonalm edited a comment on pull request #309: WIP change scoped enums behavior
Posted by GitBox <gi...@apache.org>.
jonalm edited a comment on pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309#issuecomment-1073125929
On second thought that `T` idea brakes down (without careful handleing) for enums containing `T` fields, which I guess are way more likely than `_<enumname>`.
edit:
I changed it to inner type name to `__TYPE__` , as it is equal across different enums (which are identified by module name), and not likely to be an enum value name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] jonalm commented on pull request #309: WIP change scoped enums behavior
Posted by GitBox <gi...@apache.org>.
jonalm commented on pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309#issuecomment-1073125929
On second thought that `T` idea brakes down (without careful handleing) for enums containing `T` fields, which I guess are way more likely than `_<enumname>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] jonalm edited a comment on pull request #309: WIP change scoped enums behavior
Posted by GitBox <gi...@apache.org>.
jonalm edited a comment on pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309#issuecomment-1073125929
On second thought that `T` idea brakes down (without careful handleing) for enums containing `T` fields, which I guess are way more likely than `_<enumname>`.
edit:
I changed it to inner type name to __TYPE__ , as it is equal across different enums (which are identified by module name), and not likely to be an enum value name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #309: WIP change scoped enums behavior
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #309:
URL: https://github.com/apache/arrow-julia/pull/309#issuecomment-1076870921
# [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#309](https://codecov.io/gh/apache/arrow-julia/pull/309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66457b7) into [main](https://codecov.io/gh/apache/arrow-julia/commit/9b4de2b8fa8c24bcc3a85aecaa7eede1ebfa26f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b4de2b) will **increase** coverage by `0.03%`.
> The diff coverage is `79.61%`.
```diff
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 86.99% 87.02% +0.03%
==========================================
Files 26 26
Lines 3267 3267
==========================================
+ Hits 2842 2843 +1
+ Misses 425 424 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-julia/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/metadata/File.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21ldGFkYXRhL0ZpbGUuamw=) | `30.61% <33.33%> (ø)` | |
| [src/eltypes.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2VsdHlwZXMuamw=) | `86.55% <60.71%> (ø)` | |
| [src/metadata/Message.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21ldGFkYXRhL01lc3NhZ2Uuamw=) | `77.68% <62.50%> (ø)` | |
| [src/FlatBuffers/FlatBuffers.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL0ZsYXRCdWZmZXJzL0ZsYXRCdWZmZXJzLmps) | `73.17% <75.00%> (ø)` | |
| [src/metadata/Schema.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21ldGFkYXRhL1NjaGVtYS5qbA==) | `84.35% <91.66%> (ø)` | |
| [src/arraytypes/arraytypes.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FycmF5dHlwZXMvYXJyYXl0eXBlcy5qbA==) | `89.32% <100.00%> (ø)` | |
| [src/arraytypes/bool.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FycmF5dHlwZXMvYm9vbC5qbA==) | `88.70% <100.00%> (ø)` | |
| [src/arraytypes/compressed.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FycmF5dHlwZXMvY29tcHJlc3NlZC5qbA==) | `100.00% <100.00%> (ø)` | |
| [src/arraytypes/dictencoding.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FycmF5dHlwZXMvZGljdGVuY29kaW5nLmps) | `75.58% <100.00%> (ø)` | |
| [src/arraytypes/fixedsizelist.jl](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FycmF5dHlwZXMvZml4ZWRzaXplbGlzdC5qbA==) | `84.53% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/arrow-julia/pull/309/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-julia/pull/309?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/309?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9b4de2b...66457b7](https://codecov.io/gh/apache/arrow-julia/pull/309?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org