You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/01 06:34:16 UTC
[GitHub] codecov-io edited a comment on issue #5771: [dashboard] Add alert
when user deleting root level tab
codecov-io edited a comment on issue #5771: [dashboard] Add alert when user deleting root level tab
URL: https://github.com/apache/incubator-superset/pull/5771#issuecomment-417071338
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=h1) Report
> Merging [#5771](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8a4b1b7c25a8234ac1641add38645a08fb338dd1?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5771 +/- ##
==========================================
+ Coverage 63.78% 63.79% +0.01%
==========================================
Files 364 365 +1
Lines 23111 23138 +27
Branches 2587 2591 +4
==========================================
+ Hits 14741 14762 +21
- Misses 8355 8361 +6
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ts/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWIuanN4) | `82.43% <100%> (-3.87%)` | :arrow_down: |
| [superset/assets/src/components/ModalTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01vZGFsVHJpZ2dlci5qc3g=) | `97.22% <100%> (+0.16%)` | :arrow_up: |
| [.../src/dashboard/components/menu/WithPopoverMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9tZW51L1dpdGhQb3BvdmVyTWVudS5qc3g=) | `82.45% <50%> (+0.31%)` | :arrow_up: |
| [.../src/dashboard/components/DeleteComponentModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EZWxldGVDb21wb25lbnRNb2RhbC5qc3g=) | `86.95% <86.95%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=footer). Last update [8a4b1b7...3cf7f60](https://codecov.io/gh/apache/incubator-superset/pull/5771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org