You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/04/21 10:48:03 UTC

[GitHub] zeppelin pull request #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts ...

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2274

    [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

    ## What is this PR for?
    This PR is for Improving the keyboard shortcuts dialog form and here is what i improve.
    - change to table shape
    - add scrollbar
    - fixed that text is misaligned when resizing windows
    
    ## What type of PR is it?
    [Bug fix | Improvement]
    
    ## What is the Jira issue?
    * [ZEPPELIN-2388; Prettify Keyboard Shortcut Dialog](https://issues.apache.org/jira/browse/ZEPPELIN-2388)
    
    ## How should this be tested?
    1. Click `Keyboard Shortcuts' icon in a paragraph.
    2. Check `Keyboard Shortcuts` shape.
    3. Check resizing windows.
    
    ## Screenshots (if appropriate)
    ### [Before - default]
    ![old_keyboard_shortcut](https://cloud.githubusercontent.com/assets/8110458/25274009/412a3f68-26c9-11e7-82ac-07835a04de83.png)
    
    ### [Before  - 1. text is misaligned when resizing windows]
    ![broken_shortcuts](https://cloud.githubusercontent.com/assets/8110458/25274381/c27c75d0-26ca-11e7-9262-4955bc4fcd42.png)
    
    ### [Before - 2. not scrollbar]
    ![need_scrollbar](https://cloud.githubusercontent.com/assets/8110458/25274313/76b4097e-26ca-11e7-8f11-599629c6c2b3.gif)
    
    
    ### [After - 1. default]
    ![new_keboard_shortcuts](https://cloud.githubusercontent.com/assets/8110458/25274041/5919f2bc-26c9-11e7-82a9-bd25526b118b.gif)
    
    ### [After - 2. resizing windows (my image is a little broken.)]
    ![resizing_shortcut](https://cloud.githubusercontent.com/assets/8110458/25274044/5c4e7494-26c9-11e7-9f23-2dbf2c9cf40f.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2388_shortcut_key

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2274
    
----
commit 6ce8954ebfc671e863c85af34353d8bd87bc14e7
Author: soralee <so...@zepl.com>
Date:   2017-04-21T10:20:49Z

    improve the keyboard shortcuts dialog

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    LGTM!!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    LGTM and merge to master if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    great - just my preference - I actually like the tighter spacing and without line separator look better...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by soralee <gi...@git.apache.org>.

Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    CI failed but irrelevant.
    ```
    Tests in error: 
      SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce...
      SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException...
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    very nice! LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    awesome!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by soralee <gi...@git.apache.org>.

Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    Thank you @1ambda @felixcheung for seeing this!
    Yeah, I like @1ambda's opinions! Let me update those as @1ambda's comments.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2274
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---