You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/02 21:14:46 UTC

[GitHub] [iceberg] jackye1995 opened a new issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

jackye1995 opened a new issue #3657:
URL: https://github.com/apache/iceberg/issues/3657


   For project code consistency, we should add checkstyle rules that prevent the use of raw `new HashMap<>`, `new HashSet<>()` and `new ArrayList<>` in favor of `Maps.newHashMap()`, `Sets.newHashSet()` and `Lists.newArrayList()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] jackye1995 closed issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

Posted by GitBox <gi...@apache.org>.
jackye1995 closed issue #3657:
URL: https://github.com/apache/iceberg/issues/3657


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] hililiwei commented on issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

Posted by GitBox <gi...@apache.org>.
hililiwei commented on issue #3657:
URL: https://github.com/apache/iceberg/issues/3657#issuecomment-985130313


   I'd like to try it. May I have the ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] felixYyu commented on issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

Posted by GitBox <gi...@apache.org>.
felixYyu commented on issue #3657:
URL: https://github.com/apache/iceberg/issues/3657#issuecomment-1066259373


   can you take a look the patch. cc @jackye1995 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] jackye1995 commented on issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

Posted by GitBox <gi...@apache.org>.
jackye1995 commented on issue #3657:
URL: https://github.com/apache/iceberg/issues/3657#issuecomment-985135717


   assigned!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] hililiwei commented on issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

Posted by GitBox <gi...@apache.org>.
hililiwei commented on issue #3657:
URL: https://github.com/apache/iceberg/issues/3657#issuecomment-997141092


   merged master: 2531545e3cd3b97494c9e3c137cfe04f4459a9fb


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] felixYyu removed a comment on issue #3657: Add checkstyle rule to prevent using raw HashMap, HashSet, ArrayList

Posted by GitBox <gi...@apache.org>.
felixYyu removed a comment on issue #3657:
URL: https://github.com/apache/iceberg/issues/3657#issuecomment-1066259373


   can you take a look the patch. cc @jackye1995 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org